td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 40
Total Committers: 14
Last Commit: 13 Mar
Commits this week: 40

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 13 Mar
3:24 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
3:23 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Monitors/Pressures.c
    • -1
    • +1
    ./Monitors/Pressures.h
3:21 pm

Vendor - TEL - Praneeth Bunne

3:04 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' into LDT-1840-Transmembrane-Pressure-update

Options
    • -1
    • +35
    ./Monitors/Pressures.c
    • -1
    • +3
    ./Monitors/Pressures.h
2:59 pm

Vendor - TEL - Varshini Nagabooshanam

2:58 pm

Zoltan Miskolci and Sean Nash

2:57 pm

Sean Nash

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 ...

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 minute (60 secs) and we need to alarm more severely when countdown reaches 0 secs.

If you make the 2 times static (not local here), you can call a monitor function from exec and do the calculations for the times and trigger alarms in the monitor function. Then, here in publish function, you would just publish the static times (no need to calculate because it's already done all the time).

2:51 pm

Sean Nash

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

2:47 pm

Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash

2:43 pm

Sean Nash

Use MS_PER_SECOND (in Common.h I think) instead of 1000. Also, make sure elapsedSec does not exceed timeout (300) so countdown doesn't go negative.

Use MS_PER_SECOND (in Common.h I think) instead of 1000.
Also, make sure elapsedSec does not exceed timeout (300) so countdown doesn't go negative.

2:39 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

2:39 pm

Sean Nash

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

2:39 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:38 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-1840-Transmembrane-Pressure-update

Options
    • -1
    • +0
    ./Monitors/Pressures.c
    • -0
    • +2
    ./Monitors/Pressures.h
2:35 pm

Sean Nash

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

2:35 pm

Sean Nash

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

2:34 pm

Sean Nash

I think we can initialize to zero here. We haven't paused yet.

I think we can initialize to zero here. We haven't paused yet.

2:33 pm

Sean Nash

Align with others (after U32).

Align with others (after U32).

2:26 pm

Sean Nash

Still not packed.

Still not packed.

2:25 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:23 pm

Sean Nash

2:19 pm

Vendor - TEL - Varshini Nagabooshanam

Sure

Sure

1:45 pm

Vinayakam Mani

Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

12:19 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
12:18 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/BloodFlow.h
    • -2
    • +2
    ./Drivers/PeristalticPump.c
    • -2
    • +2
    ./Drivers/PeristalticPump.h
    • -2
    • +2
    ./Services/FpgaTD.c
    • -2
    • +2
    ./Services/FpgaTD.h
    • -2
    • +2
    ./Services/Messaging.c
12:04 pm

Vendor - TEL - Jashwant Gantyada

12:03 pm

Sean Nash and Raghu Kallala

11:59 am

Vendor - TEL - Jashwant Gantyada

done updated below in the function as well.

done updated below in the function as well.

11:59 am

Vendor - TEL - Jashwant Gantyada

done.

done.

11:57 am

Vendor - TEL - Jashwant Gantyada

LDT-1394 addressed code review comments

Options
    • -1
    • +1
    ./Controllers/BloodFlow.h
    • -3
    • +3
    ./Services/FpgaTD.c