dd-firmware / firmware / App / Controllers

BalancingChamber.c

Clone Tools

Stats

Commits this week: 8
Total Committers: 8
Last Commit: 12:47
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 04 Mar
2:05 pm

Sean Nash

Looked better before - now misspelled.

Looked better before - now misspelled.

2:04 pm

Sean Nash

0.0F

0.0F

2:04 pm

Sean Nash

indent looks 1 space off.

indent looks 1 space off.

2:01 pm

Sean Nash

If we include math, I like to see comment explaining what we're doing with it. Why remove it?

If we include math, I like to see comment explaining what we're doing with it. Why remove it?

2:00 pm

Sean Nash

Declare at top of scope, assign down here if needed.

Declare at top of scope, assign down here if needed.

1:59 pm

Sean Nash

If there is only one target temperature, why are we passing in a heater ID to function? This seems weird to me having both heaters share a target.

If there is only one target temperature, why are we passing in a heater ID to function? This seems weird to me having both heaters share a target.

1:57 pm

Sean Nash

Remove blank line.

Remove blank line.

1:56 pm

Sean Nash

Which heater does single target temp apply to? Or does same target apply to both heaters?

Which heater does single target temp apply to? Or does same target apply to both heaters?

1:53 pm

Sean Nash

I don't see ufVolumeperIteration being set in this function - why did you add it to Outputs?

I don't see ufVolumeperIteration being set in this function - why did you add it to Outputs?

1:51 pm

Sean Nash

Remove blank line.

Remove blank line.

1:51 pm

Sean Nash

return should be "none"

return should be "none"

1:51 pm

Sean Nash

Why 2 Inputs?

Why 2 Inputs?

1:51 pm

Sean Nash

return should be "none"

return should be "none"

1:50 pm

Sean Nash

return should be "none"

return should be "none"

1:49 pm

Sean Nash

Why 2 inputs?

Why 2 inputs?

1:49 pm

Sean Nash

Why 2 Inputs?

Why 2 Inputs?

1:49 pm

Sean Nash

Do we really need 64 bits for this?

Do we really need 64 bits for this?

1:46 pm

Sean Nash

Remove blank line.

Remove blank line.

1:45 pm

Sean Nash

Add blank line after private data banner.

Add blank line after private data banner.

1:41 pm

Sean Nash

Did this get moved somewhere?

Did this get moved somewhere?

1:37 pm

Sean Nash

Seemed right before. Now misspelled.

Seemed right before. Now misspelled.

10:43 am

Vendor - TEL - Sameer Poyil

10:15 am

Vinayakam Mani

10:15 am

Vinayakam Mani

9:52 am

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:02 am

Sean Nash

Use uppercase F

Use uppercase F

9:01 am

Sean Nash

Please declare local variables at top of scope (line 309 in this case).

Please declare local variables at top of scope (line 309 in this case).

Wednesday 25 Feb
3:31 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
1:47 pm

Sean Nash

DO NOT REVIEW - temporary branch to support new Diener 1000 pump changes. Will delete branch and CR when done.

DO NOT REVIEW - temporary branch to support new Diener 1000 pump changes. Will delete branch and CR when done.

1:35 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed