dd-firmware / firmware / App / Modes / FPModes

ModeGenPermeateDefeatured.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 7
Last Commit: 12:47
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

Sean Nash

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

6 hrs ago

Sean Nash

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request. We should do whatever is needed (if an...

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request.
We should do whatever is needed (if anything) to start the mode normally in an else.
And we should return TRUE/FALSE in these signal functions so that when it's called from Dialin msg handler, the msg handler can return ACK/NAK to Dialin if sub mode is invalid.

6 hrs ago

Sean Nash

We shouldn't request op mode until we're sure we're happy with the whole thing. Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just re...

We shouldn't request op mode until we're sure we're happy with the whole thing.
Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just request new sub mode if not already in it. If not, the currentSubMode checked below is not relevant (applies to current mode, not the requested mode) and we need to request new op mode and signal that new op mode that we will want to start in a specific sub mode.

6 hrs ago

Sean Nash

Declarations should be at top of scope (right before memcpy).

Declarations should be at top of scope (right before memcpy).

6 hrs ago

Sean Nash

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

6 hrs ago

Sean Nash

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

6 hrs ago

Sean Nash

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

8 hrs ago

Raghu Kallala

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean NashMichael Garthwaite please confirm

8 hrs ago

Raghu Kallala

I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

10 hrs ago

Michael Garthwaite

Yes since you're not using the return value in execOpModes()

Yes since you're not using the return value in execOpModes()

Thursday 05 Mar
7:32 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP sub system
LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP sub system
Thursday 15 Jan
4:08 pm

Raghu Kallala

4:08 pm

Michael Garthwaite and Sean Nash

10:59 am

Raghu Kallala

added param and output

added param and output

10:52 am

Raghu Kallala

Added struct packing

Added struct packing

9:41 am

Sean Nash

Update function header to include message param.

Update function header to include message param.

9:40 am

Sean Nash

This structure is for message payload. There is nothing to pack in this specific structure, but I think we should be in the habit of packing ALL payload structures in case a future structure change...

This structure is for message payload. There is nothing to pack in this specific structure, but I think we should be in the habit of packing ALL payload structures in case a future structure change does require packing.

9:15 am

Raghu Kallala

removed

removed

Wednesday 14 Jan
3:11 pm

Raghu Kallala

Fixed

Fixed

3:06 pm

Raghu Kallala

done

done

3:06 pm

Raghu Kallala

Updated

Updated

3:06 pm

Raghu Kallala

Fixed

Fixed

3:05 pm

Raghu Kallala

Fixed

Fixed

3:05 pm

Raghu Kallala

Fixed

Fixed

3:05 pm

Raghu Kallala

Fixed

Fixed

2:23 pm

Sean Nash

I don't see fix. I'm resolving this comment, but I added another comment that hopefully clarifies the issue.

I don't see fix. I'm resolving this comment, but I added another comment that hopefully clarifies the issue.

2:15 pm

Sean Nash

Missing message param.

Missing message param.

2:15 pm

Sean Nash

Message handling functions must take a message as parameter (i.e. prototype of function should look like BOOL funcName( MESSAGE_T *message );

Message handling functions must take a message as parameter (i.e. prototype of function should look like BOOL funcName( MESSAGE_T *message );

2:13 pm

Sean Nash

Calculated is mis-spelled.

Calculated is mis-spelled.

2:12 pm

Sean Nash

If this function is only called from here, should we just move the function's code into this function (i.e. combine the functions)?

If this function is only called from here, should we just move the function's code into this function (i.e. combine the functions)?