Services

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3603 initial draft for FP set operation sub mode

  1. … 10 more files in changeset.
LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP sub system
LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP sub system
Looked better before - now misspelled.

Looked better before - now misspelled.

0.0F

0.0F

indent looks 1 space off.

indent looks 1 space off.

If we include math, I like to see comment explaining what we're doing with it. Why remove it?

If we include math, I like to see comment explaining what we're doing with it. Why remove it?

Declare at top of scope, assign down here if needed.

Declare at top of scope, assign down here if needed.

If there is only one target temperature, why are we passing in a heater ID to function? This seems weird to me having both heaters share a target.

If there is only one target temperature, why are we passing in a heater ID to function? This seems weird to me having both heaters share a target.

Remove blank line.

Remove blank line.

Which heater does single target temp apply to? Or does same target apply to both heaters?

Which heater does single target temp apply to? Or does same target apply to both heaters?

I don't see ufVolumeperIteration being set in this function - why did you add it to Outputs?

I don't see ufVolumeperIteration being set in this function - why did you add it to Outputs?

Remove blank line.

Remove blank line.

return should be "none"

return should be "none"

Why 2 Inputs?

Why 2 Inputs?

return should be "none"

return should be "none"

return should be "none"

return should be "none"

Why 2 inputs?

Why 2 inputs?

Why 2 Inputs?

Why 2 Inputs?

Do we really need 64 bits for this?

Do we really need 64 bits for this?

Remove blank line.

Remove blank line.

Add blank line after private data banner.

Add blank line after private data banner.

Did this get moved somewhere?

Did this get moved somewhere?

Seemed right before. Now misspelled.

Seemed right before. Now misspelled.

Use uppercase F

Use uppercase F

Please declare local variables at top of scope (line 309 in this case).

Please declare local variables at top of scope (line 309 in this case).

DO NOT REVIEW - temporary branch to support new Diener 1000 pump changes. Will delete branch and CR when done.

DO NOT REVIEW - temporary branch to support new Diener 1000 pump changes. Will delete branch and CR when done.

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 9 more files in changeset.