dd-firmware / firmware / App / Controllers

Heaters.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 4
Last Commit: 12 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
4 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

4 hrs ago

Sean Nash

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

4 hrs ago

Sean Nash

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

4 hrs ago

Sean Nash

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)? Controller properties already include a min and max field - can we use those?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

5 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

Thursday 12 Mar
3:43 pm

Vinayakam Mani

Done.

Done.

3:42 pm

Vinayakam Mani

Done.

Done.

Tuesday 10 Mar
1:44 pm

Vinayakam Mani

Wednesday 04 Mar
2:05 pm

Sean Nash

Looked better before - now misspelled.

Looked better before - now misspelled.

2:04 pm

Sean Nash

0.0F

0.0F

2:04 pm

Sean Nash

indent looks 1 space off.

indent looks 1 space off.

2:01 pm

Sean Nash

If we include math, I like to see comment explaining what we're doing with it. Why remove it?

If we include math, I like to see comment explaining what we're doing with it. Why remove it?

2:00 pm

Sean Nash

Declare at top of scope, assign down here if needed.

Declare at top of scope, assign down here if needed.

1:59 pm

Sean Nash

If there is only one target temperature, why are we passing in a heater ID to function? This seems weird to me having both heaters share a target.

If there is only one target temperature, why are we passing in a heater ID to function? This seems weird to me having both heaters share a target.

1:57 pm

Sean Nash

Remove blank line.

Remove blank line.

1:56 pm

Sean Nash

Which heater does single target temp apply to? Or does same target apply to both heaters?

Which heater does single target temp apply to? Or does same target apply to both heaters?

1:53 pm

Sean Nash

I don't see ufVolumeperIteration being set in this function - why did you add it to Outputs?

I don't see ufVolumeperIteration being set in this function - why did you add it to Outputs?

1:51 pm

Sean Nash

Remove blank line.

Remove blank line.

1:51 pm

Sean Nash

return should be "none"

return should be "none"

1:51 pm

Sean Nash

Why 2 Inputs?

Why 2 Inputs?

1:51 pm

Sean Nash

return should be "none"

return should be "none"

1:50 pm

Sean Nash

return should be "none"

return should be "none"

1:49 pm

Sean Nash

Why 2 inputs?

Why 2 inputs?

1:49 pm

Sean Nash

Why 2 Inputs?

Why 2 Inputs?

1:49 pm

Sean Nash

Do we really need 64 bits for this?

Do we really need 64 bits for this?

1:46 pm

Sean Nash

Remove blank line.

Remove blank line.

1:45 pm

Sean Nash

Add blank line after private data banner.

Add blank line after private data banner.

1:41 pm

Sean Nash

Did this get moved somewhere?

Did this get moved somewhere?

1:37 pm

Sean Nash

Seemed right before. Now misspelled.

Seemed right before. Now misspelled.

9:15 am

Vendor - TEL - Jashwant Gantyada and Vendor - TEL - Sameer Poyil