dd-firmware / firmware / App / Controllers

Heaters.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 2
Last Commit: 12 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
5 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

5 hrs ago

Sean Nash

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

5 hrs ago

Sean Nash

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

5 hrs ago

Sean Nash

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)? Controller properties already include a min and max field - can we use those?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

5 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

Thursday 12 Mar
3:43 pm

Vinayakam Mani

Done.

Done.

3:42 pm

Vinayakam Mani

Done.

Done.

Wednesday 25 Feb
12:49 pm

Vendor - TEL - Sameer Poyil

mis aligned ?

mis aligned ?

12:48 pm

Vendor - TEL - Sameer Poyil

mis aligned ?

mis aligned ?

Monday 23 Feb
6:29 pm

Vendor - TEL - Sameer Poyil

need a brief description about this feature and how it is implemented/logic/math etc - also comment on the previous logic

need a brief description about this feature and how it is implemented/logic/math etc - also comment on the previous logic

6:27 pm

Vendor - TEL - Sameer Poyil

its a reverse logic - is it OK to make positive instead of not defined ?

its a reverse logic - is it OK to make positive instead of not defined ?

Friday 13 Feb
3:47 pm

Sean Nash

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode? Even if all dialysate heating is done in this mode, should we consider cr...

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode?
Even if all dialysate heating is done in this mode, should we consider creating a service controller (like BC controller) to manage this complex temperature control?

3:38 pm

Sean Nash

Resolve merge conflicts.

Resolve merge conflicts.

Tuesday 10 Feb
5:03 pm

Sean Nash

Add blank line between declarations and rest of code.

Add blank line between declarations and rest of code.

5:02 pm

Sean Nash

Add comment to right listing which math functions we're using.

Add comment to right listing which math functions we're using.

12:04 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic
LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic
Monday 08 Sep 2025
12:01 pm

Vinayakam Mani

Wednesday 03 Sep 2025
1:02 pm

Michael Garthwaite and Sean Nash

Tuesday 02 Sep 2025
3:01 pm

Vinayakam Mani

Done.

Done.

3:01 pm

Vinayakam Mani

Removed.

Removed.

3:01 pm

Vinayakam Mani

Done.

Done.

3:00 pm

Vinayakam Mani

Done.

Done.

Tuesday 26 Aug 2025
1:09 pm

Sean Nash

Same comment - pend transition until BC cycle completes.

Same comment - pend transition until BC cycle completes.

1:09 pm

Sean Nash

Consider keeping the transition to spent chamber fill pending until balancing chamber cycle completes.

Consider keeping the transition to spent chamber fill pending until balancing chamber cycle completes.

11:34 am

Sean Nash

Is this the right place to close the BC valves? Maybe it should be in transitionToBalChamberFill()? If we come back to this bypass state from delivery state, is it appropriate to close BC valves here?

Is this the right place to close the BC valves? Maybe it should be in transitionToBalChamberFill()?
If we come back to this bypass state from delivery state, is it appropriate to close BC valves here?

9:53 am

Sean Nash

Align comment.

Align comment.

Tuesday 19 Aug 2025
1:51 pm

Dara Navaei

DD-LDT-1873_Dialysate Flow Rate DD
DD-LDT-1873_Dialysate Flow Rate DD
Monday 18 Aug 2025
10:36 am

Vinayakam Mani

10:21 am

Michael Garthwaite and Sean Nash

9:58 am

Vinayakam Mani

Done.

Done.