leahi-fwcommon

Clone Tools

Stats

Commits this week: 9
Total Committers: 13
Last Commit: 06 Apr
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Apr
2:14 pm

Sean Nash

2:12 pm

Vinayakam Mani

2:12 pm

Sean Nash

1:37 pm

Sean Nash

Is it an enum/index like Denali then?

Is it an enum/index like Denali then?

1:06 pm

Raghu Kallala

1:00 pm

Raghu Kallala

LDT-3676 LDT-3677 merge latest from staging

Options
    • -3
    • +3
    /TestSupport.h
12:43 pm

Raghu Kallala

No we are not getting conv factor from UI on it I will have to confirm with Nick to see if we will get the bicarbConvFactor

No we are not getting conv factor from UI on it
I will have to confirm with Nick to see if we will get the bicarbConvFactor

12:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /TestSupport.h
12:20 pm

Vinayakam Mani

LDT-1477 merge to staging

Options
    • -1
    • +1
    /TestSupport.h
11:52 am

Vendor - TEL - Jashwant Gantyada and Sean Nash

11:01 am

Michael Garthwaite and Sean Nash

11:01 am

Sean Nash

Align comments.

Align comments.

10:57 am

Sean Nash

Can we just remove this?

Can we just remove this?

10:57 am

Sean Nash

Can we just remove this?

Can we just remove this?

10:56 am

Sean Nash

F suffix.

F suffix.

10:52 am

Sean Nash

Is bicarbonate also a conversion factor?

Is bicarbonate also a conversion factor?

10:49 am

Sean Nash

Can we just remove the old enum now?

Can we just remove the old enum now?

10:30 am

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

10:27 am

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

10:24 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

10:16 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
10:04 am

Raghu Kallala

Friday 03 Apr
3:35 pm

Vinayakam Mani

Done.

Done.

3:34 pm

Vinayakam Mani

Done

Done

3:34 pm

Vinayakam Mani

Done.

Done.

1:20 pm

Sean Nash

Same comment.

Same comment.

1:19 pm

Sean Nash

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

1:14 pm

Sean Nash

Input is d78TempAvgC

Input is d78TempAvgC

1:13 pm

Sean Nash

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

Thursday 02 Apr
3:43 pm

Vinayakam Mani

Done.

Done.