dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 17
Total Committers: 13
Last Commit: 30 Mar
Commits this week: 17

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
12 mins ago

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

15 mins ago

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

18 mins ago

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

19 mins ago

Sean Nash

20 mins ago

Vinayakam Mani

Remove this reference (across the file) if the implementation is updated.

Remove this reference (across the file) if the implementation is updated.

25 mins ago

Vinayakam Mani

Update the deadband timing in the comments.

Update the deadband timing in the comments.

27 mins ago

Vinayakam Mani

Remove blank line. Also, add comments on the key logics for reference.

Remove blank line. Also, add comments on the key logics for reference.

34 mins ago

Vinayakam Mani

Default case rise count should be 2, instead of 1?

Default case rise count should be 2, instead of 1?

37 mins ago

Vinayakam Mani

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

1 hr ago

Vinayakam Mani

The BC valves not even opened and collecting the spent dial pressure as last previous spent dial pressure may not be correct.

The BC valves not even opened and collecting the spent dial pressure as last previous spent dial pressure may not be correct.

Friday 03 Apr
3:35 pm

Vinayakam Mani

Done.

Done.

3:34 pm

Vinayakam Mani

Done

Done

3:34 pm

Vinayakam Mani

Done.

Done.

1:20 pm

Sean Nash

Same comment.

Same comment.

1:19 pm

Sean Nash

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

1:14 pm

Sean Nash

Input is d78TempAvgC

Input is d78TempAvgC

1:13 pm

Sean Nash

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

9:31 am

Vendor - TEL - Jashwant Gantyada

8:34 am

Sean Nash

8:32 am

Sean Nash

Thursday 02 Apr
3:43 pm

Vinayakam Mani

Done.

Done.

3:43 pm

Vinayakam Mani

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

3:40 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:35 pm

Vinayakam Mani

3:28 pm

Vinayakam Mani

Done.

Done.

3:28 pm

Vinayakam Mani

Done.

Done.

3:27 pm

Vinayakam Mani

Done.

Done.

3:27 pm

Vinayakam Mani

Done.

Done.