leahi-common

Clone Tools

Stats

Commits this week: 13
Total Committers: 16
Last Commit: 02 Apr
Commits this week: 13

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 min ago

Raghu Kallala

No we are not getting conv factor from UI on it I will have to confirm with Nick to see if we will get the bicarbConvFactor

No we are not getting conv factor from UI on it
I will have to confirm with Nick to see if we will get the bicarbConvFactor

1 hr ago

Vinayakam Mani

Balancing chamber switching control

Balancing chamber switching control

1 hr ago

Vinayakam Mani

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled f...

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled first.

1 hr ago

Vinayakam Mani

remove the space before false.

remove the space before false.

1 hr ago

Vinayakam Mani

Remove blank line

Remove blank line

1 hr ago

Vinayakam Mani

Remove blank line.

Remove blank line.

1 hr ago

Michael Garthwaite and Sean Nash

1 hr ago

Sean Nash

Align comments.

Align comments.

1 hr ago

Sean Nash

1 hr ago

Sean Nash

1 hr ago

Sean Nash

Can we just remove this?

Can we just remove this?

1 hr ago

Sean Nash

Can we just remove this?

Can we just remove this?

1 hr ago

Sean Nash

F suffix.

F suffix.

1 hr ago

Sean Nash

Is bicarbonate also a conversion factor?

Is bicarbonate also a conversion factor?

1 hr ago

Sean Nash

Can we just remove the old enum now?

Can we just remove the old enum now?

1 hr ago

Vendor - TEL - Arpita Srivastava

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

2 hrs ago

Sean Nash

2 hrs ago

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

2 hrs ago

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

2 hrs ago

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

2 hrs ago

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
2 hrs ago

Raghu Kallala

Friday 03 Apr
3:35 pm

Vinayakam Mani

Done.

Done.

3:34 pm

Vinayakam Mani

Done

Done

3:34 pm

Vinayakam Mani

Done.

Done.

1:20 pm

Sean Nash

Same comment.

Same comment.

1:19 pm

Sean Nash

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

1:14 pm

Sean Nash

Input is d78TempAvgC

Input is d78TempAvgC

1:13 pm

Sean Nash

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

Thursday 02 Apr
3:43 pm

Vinayakam Mani

Done.

Done.