dd-firmware / firmware / App / Monitors

Temperature.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 8
Last Commit: 20 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

Vinayakam Mani

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

9 hrs ago

Vinayakam Mani

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

9 hrs ago

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

9 hrs ago

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

9 hrs ago

Vinayakam Mani

Done.

Done.

9 hrs ago

Vinayakam Mani

Done.

Done.

Monday 06 Apr
2:12 pm

Vinayakam Mani

11:52 am

Vendor - TEL - Jashwant Gantyada and Sean Nash

10:30 am

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

10:27 am

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

10:24 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

Friday 03 Apr
3:35 pm

Vinayakam Mani

Done.

Done.

3:34 pm

Vinayakam Mani

Done

Done

3:34 pm

Vinayakam Mani

Done.

Done.

1:20 pm

Sean Nash

Same comment.

Same comment.

1:19 pm

Sean Nash

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

1:14 pm

Sean Nash

Input is d78TempAvgC

Input is d78TempAvgC

1:13 pm

Sean Nash

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

Thursday 02 Apr
3:43 pm

Vinayakam Mani

Done.

Done.

3:43 pm

Vinayakam Mani

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

3:40 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:28 pm

Vinayakam Mani

Done.

Done.

3:28 pm

Vinayakam Mani

Done.

Done.

3:27 pm

Vinayakam Mani

Done.

Done.

3:27 pm

Vinayakam Mani

Done.

Done.

9:04 am

Sean Nash

9:04 am

Sean Nash

Reverse order of comparison

Reverse order of comparison

9:03 am

Sean Nash

Reverse order of comparison.

Reverse order of comparison.