dd-firmware / firmware / App

Monitors

Clone Tools

Stats

Commits this week: 1
Total Committers: 15
Last Commit: 30 Jun
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 08 Jul
1:48 pm

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

1:45 pm

Vinayakam Mani

Did you get a chance to test this alarm and uncomment the code?

Did you get a chance to test this alarm and uncomment the code?

1:44 pm

Vinayakam Mani

Remove empty space.

Remove empty space.

1:44 pm

Vinayakam Mani

ACToDC?

ACToDC?

1:42 pm

Vinayakam Mani

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

10:41 am

Sean Nash

Align comment. Clarify (at least in comments) that these macros are for FPGA count conversions.

Align comment.
Clarify (at least in comments) that these macros are for FPGA count conversions.

10:38 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

Monday 06 Jul
12:59 pm

Sean Nash

What is 4 (or 2)? Should be #define or enum or const.

What is 4 (or 2)? Should be #define or enum or const.

Wednesday 01 Jul
9:04 pm

Vendor - TEL - Sameer Poyil

please align this comments with below structure

please align this comments with below structure

9:03 pm

Vendor - TEL - Sameer Poyil

Please align the comments

Please align the comments

8:59 pm

Vendor - TEL - Sameer Poyil

could you please align it ?

could you please align it ?

6:08 pm

Sean Nash

Add blank line (should be 2 before test support banner).

Add blank line (should be 2 before test support banner).

6:07 pm

Sean Nash

Remove blank line.

Remove blank line.

6:06 pm

Sean Nash

Needs doxygen comments.

Needs doxygen comments.

1:18 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:18 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:17 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:17 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:17 pm

Michael Garthwaite

Reverted change. Added uncompensated conductivity to the conductivity publishing

Reverted change. Added uncompensated conductivity to the conductivity publishing

11:02 am

Vinayakam Mani

space after if.

space after if.

11:02 am

Vinayakam Mani

Space after if.

Space after if.

10:59 am

Vinayakam Mani

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

10:58 am

Vendor - TEL - Jashwant Gantyada

10:57 am

Vendor - TEL - Jashwant Gantyada

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

10:57 am

Vinayakam Mani

Remove empty line.

Remove empty line.

10:54 am

Vinayakam Mani

Align the indentation

Align the indentation

10:54 am

Vinayakam Mani

Align the indentation.

Align the indentation.

Friday 26 Jun
1:41 pm

Vinayakam Mani

Same as above.

Same as above.

1:39 pm

Vinayakam Mani

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

1:37 pm

Vinayakam Mani

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)