dd-firmware

Clone Tools

Stats

Commits this week: 39
Total Committers: 16
Last Commit: 11:23
Commits this week: 39

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 mins ago

Sean Nash

Remove this blank line.

Remove this blank line.

4 mins ago

Sean Nash

Put () around each of the 2 conditions being ANDed.

Put () around each of the 2 conditions being ANDed.

5 mins ago

Sean Nash

Remove blank line.

Remove blank line.

5 mins ago

Sean Nash

Remove blank line.

Remove blank line.

7 mins ago

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

8 mins ago

Sean Nash

Remove blank line.

Remove blank line.

8 mins ago

Sean Nash

Should we remove this else if or is it going to be restored later?

Should we remove this else if or is it going to be restored later?

12 mins ago

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

12 mins ago

Sean Nash

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

13 mins ago

Sean Nash

Why do we need this?

Why do we need this?

15 mins ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

16 mins ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

20 mins ago

Sean Nash

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

23 mins ago

Sean Nash

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above. What does nr stand for?

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

25 mins ago

Sean Nash

Let's remove this commented line.

Let's remove this commented line.

31 mins ago

Sean Nash

Add blank line before return.

Add blank line before return.

32 mins ago

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

33 mins ago

Sean Nash

Why U32? Why not RECOVER_STATE_T?

Why U32? Why not RECOVER_STATE_T?

35 mins ago

Sean Nash

Lower case x

Lower case x

36 mins ago

Sean Nash

Is blood flow in need of a PID controller too?

Is blood flow in need of a PID controller too?

52 mins ago

Sean Nash

2 blank lines before test support banner

2 blank lines before test support banner

53 mins ago

Sean Nash

Add blank line before return.

Add blank line before return.

53 mins ago

Sean Nash

Add blank line before return.

Add blank line before return.

1 hr ago

Sean Nash

3 hrs ago

Raghu Kallala

LDT-3904 added FP operation status event

Options
    • -2
    • +31
    /firmware/App/Modes/FPModes/FPOperationModes.c
3 hrs ago

Vendor - TEL - Sameer Poyil

I don't need to edit this file. I will check with Dara to exclude this file from code review.

I don't need to edit this file. I will check with Dara to exclude this file from code review.

3 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
3 hrs ago

Vendor - TEL - Jashwant Gantyada

3 hrs ago

Vendor - TEL - Jashwant Gantyada

3 hrs ago

Vendor - TEL - Sameer Poyil

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals. need to split it or need two message id.

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals.
need to split it or need two message id.