td-firmware / firmware / App / Controllers

Ejector.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 03 May
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 06 May
1:58 pm

Sean Nash and Vendor - TEL - Varshini Nagabooshanam

11:43 am

Sean Nash

Treatment mode will also need one of these (later). Should we add PreTx to the function name to differentiate?

Treatment mode will also need one of these (later). Should we add PreTx to the function name to differentiate?

Tuesday 05 May
12:10 pm

Vendor - TEL - Varshini Nagabooshanam

Add a detail for Message Sent for the broadcast data message.

Add a detail for Message Sent for the broadcast data message.

12:09 pm

Vendor - TEL - Varshini Nagabooshanam

create local Bool

create local Bool

11:54 am

Vendor - TEL - Varshini Nagabooshanam

Add a detail for Message Sent for the broadcast data message.

Add a detail for Message Sent for the broadcast data message.

11:49 am

Vendor - TEL - Varshini Nagabooshanam

There should be a \b before the type of details update it for all

There should be a \b before the type of details
update it for all

11:48 am

Vendor - TEL - Arpita Srivastava

please add a comment.

please add a comment.

11:47 am

Vendor - TEL - Arpita Srivastava

How are we entering the complete state? If we are planning to implement this function later, can we please add a TODO?

How are we entering the complete state? If we are planning to implement this function later, can we please add a TODO?

11:45 am

Vendor - TEL - Varshini Nagabooshanam

There should be a \b before the type of details I/p and O/p please update for all

There should be a \b before the type of details I/p and O/p please update for all

11:44 am

Vendor - TEL - Arpita Srivastava

currentAutoEjectState should be input?

currentAutoEjectState should be input?

11:42 am

Vendor - TEL - Arpita Srivastava

currentAutoEjectState should be input?

currentAutoEjectState should be input?

11:39 am

Vendor - TEL - Arpita Srivastava

add autoEjectTimerCounter to outputs

add autoEjectTimerCounter to outputs

11:36 am

Vendor - TEL - Arpita Srivastava

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

11:36 am

Vendor - TEL - Arpita Srivastava

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.

11:35 am

Vendor - TEL - Varshini Nagabooshanam

change to ///< Tubing set install state

change to ///< Tubing set install state

11:30 am

Vendor - TEL - Varshini Nagabooshanam

11:28 am

Vendor - TEL - Varshini Nagabooshanam

Put it back

Put it back

11:27 am

Vendor - TEL - Varshini Nagabooshanam

There should be a \b before the type of details (Inputs and Outputs here) for doxygen update for all

There should be a \b before the type of details (Inputs and Outputs here) for doxygen update for all

11:26 am

Vendor - TEL - Varshini Nagabooshanam

@details \b Outputs: Please make sure to update all of them to Leahi format In this case, there should be a \b before the type of details (Inputs and Outputs here) so they will be bold when doxygen...

@details \b Outputs:
Please make sure to update all of them to Leahi format In this case, there should be a \b before the type of details (Inputs and Outputs here) so they will be bold when doxygen documentation is generated.

11:17 am

Vendor - TEL - Varshini Nagabooshanam

@details \b Inputs:

@details \b Inputs:

11:13 am

Vendor - TEL - Arpita Srivastava

Can we please add more comments in this function to explain the rationale behind the checks and the actions?

Can we please add more comments in this function to explain the rationale behind the checks and the actions?

10:51 am

Vendor - TEL - Arpita Srivastava

add a space between message and )

add a space between message and )

10:48 am

Vendor - TEL - Arpita Srivastava

Change // to /// for doxygen to catch it.

Change // to /// for doxygen to catch it.

10:31 am

Vendor - TEL - Arpita Srivastava

Can we remove the parameter and switch directly over currentPostTreatmentState?

Can we remove the parameter and switch directly over currentPostTreatmentState?

10:21 am

Vendor - TEL - Arpita Srivastava

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

10:07 am

Sean Nash

I prefer you create a local BOOL result so you can have a simpler return statement.

I prefer you create a local BOOL result so you can have a simpler return statement.

10:06 am

Sean Nash

Should go to your new complete state here.

Should go to your new complete state here.

9:59 am

Vendor - TEL - Arpita Srivastava

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

Monday 04 May
4:30 pm

Sean Nash

check alarm status instead of switch state.

check alarm status instead of switch state.

Sunday 03 May
11:44 pm

Sean Nash