leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
break this line

break this line

recircPublishTimerCtr is an output

recircPublishTimerCtr is an output

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

break this line

break this line

LEAHI-COMMON-LDT-5348_Reserve alarm IDs for development (from ID: 200 to 300)
LEAHI-COMMON-LDT-5348_Reserve alarm IDs for development (from ID: 200 to 300)
Initialization missing for the following variables in the init function. startRecircRequested reconnectRequested backToTreatmentRequested resumeRecircRequested

Initialization missing for the following variables in the init function.

startRecircRequested
reconnectRequested
backToTreatmentRequested
resumeRecircRequested

All signal flags are initialized in resetSignalFlags() which we are calling below

All signal flags are initialized in resetSignalFlags() which we are calling below

please update the alarm id reservation sheet.

please update the alarm id reservation sheet.

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out? Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out?
Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

break this line : one variable per line will be easy to read.

break this line : one variable per line will be easy to read.

StateTxRecirc should be above StateTxRinseback

StateTxRecirc should be above StateTxRinseback

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

break this line

break this line

break this line

break this line

Add rinsebackPublishTimerCtr to outputs

Add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

break this line

break this line

add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

break this line

break this line

break this into two or more lines

break this into two or more lines

break the comment in two lines

break the comment in two lines

Do we need the alarm?

Do we need the alarm?

Add fluidType to inputs

Add fluidType to inputs

Update spelling of cummulativeRinsebackVolume_mL

Update spelling of cummulativeRinsebackVolume_mL

break into two lines

break into two lines