DryBiCart.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

Nope. Since we are here after level is LOW (fill request from balancing chamber control state machine) and not filled yet. So level is still LOW

Nope. Since we are here after level is LOW (fill request from balancing chamber control state machine) and not filled yet. So level is still LOW

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Do we need to check if bicarb chamber level is high, ignore opening D80?

Do we need to check if bicarb chamber level is high, ignore opening D80?

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

Align comment

Align comment

Add comment.

Add comment.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 1 more file in changeset.
Remove space after 'Supply'.

Remove space after 'Supply'.

Align the value declaration indentation.

Align the value declaration indentation.

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

Declare local variables at top of scope.

Declare local variables at top of scope.

Add space between ( and ?

Add space between ( and ?

Remove blank line.

Remove blank line.

Why redeclare result?

Why redeclare result?

Remove blank line.

Remove blank line.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.