SystemCommDD.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

Done

Done

Done

Done

Done

Done

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

Remove extra copyright block.

Remove extra copyright block.

These 2 new channels should be using message boxes before Dialin channel message boxes. Align with buffers enum.

These 2 new channels should be using message boxes before Dialin channel message boxes. Align with buffers enum.

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

Same.

Same.

Same

Same

We shouldn't delete generated code. Add a #if 0 in this user code section and add a #endif in the user section below the coreEnableFlashEcc() call.

We shouldn't delete generated code. Add a #if 0 in this user code section and add a #endif in the user section below the coreEnableFlashEcc() call.

restored

restored

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Should be #ifndef

Should be #ifndef

Should be #ifndef I think.

Should be #ifndef I think.

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

Add a blank line after banner.

Add a blank line after banner.

Please restore before you merge to staging.

Please restore before you merge to staging.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.