leahi-fwcommon

Clone Tools

Stats

Commits this week: 11
Total Committers: 13
Last Commit: 28 May
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
26 mins ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
30 mins ago

Vinayakam Mani

Done.

Done.

1 hr ago

Vendor - TEL - Jashwant Gantyada

1 hr ago

Vendor - TEL - Jashwant Gantyada

I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

1 hr ago

Vinayakam Mani

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

1 hr ago

Vinayakam Mani

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

1 hr ago

Vinayakam Mani

as discussed, these were outcome of the test results. we will review these gains with latest controller.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

1 hr ago

Vinayakam Mani

Done.

Done.

1 hr ago

Vinayakam Mani

Done.

Done.

Thursday 28 May
10:43 pm

Sean Nash

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

10:33 pm

Sean Nash

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

10:26 pm

Sean Nash

Why comment this out? fault ID should probably be more specific (i.e. which message payload length is invalid?)

Why comment this out? fault ID should probably be more specific (i.e. which message payload length is invalid?)

4:55 pm

Sean Nash

Why isn't this TRUE == ?

Why isn't this TRUE == ?

1:47 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-TD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
1:46 pm

Sean Nash

LDT_3975: add PID for blood pump controller.

Options
    • -0
    • +3
    /PIDControllers.h
1:37 pm

Sean Nash

LDT-3975: refactored PID controller.

Options
    • -59
    • +40
    /PIDControllers.c
    • -2
    • +1
    /PIDControllers.h
Wednesday 27 May
4:28 pm

Sean Nash

Fix comment.

Fix comment.

4:24 pm

Dara Navaei

3:40 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /CommBuffers.h
    • -0
    • +16
    /Integrity.c
    • -0
    • +16
    /Integrity.h
    • -2
    • +2
    /SystemComm.c
3:36 pm

Dara Navaei

Merged LDT-3259

Options
3:34 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

2:56 pm

Dara Navaei

Done

Done

1:50 pm

Dara Navaei

LDT-3259 addressed the code review comments

Options
    • -2
    • +2
    /CommBuffers.h
1:47 pm

Dara Navaei

Done

Done

12:39 pm

Dara Navaei

This file was updated automatically using HALCoGen.

This file was updated automatically using HALCoGen.

11:37 am

Vinayakam Mani

Missing other test functions in the substitution pump (publish, target speed.)?

Missing other test functions in the substitution pump (publish, target speed.)?

11:34 am

Vinayakam Mani

update original author name and date.

update original author name and date.

11:32 am

Vinayakam Mani

update all test functions header and descriptions, Input, outputs and param sections.

update all test functions header and descriptions, Input, outputs and param sections.

11:31 am

Vinayakam Mani

Are we missing the publish function for the substitution pump?

Are we missing the publish function for the substitution pump?

11:29 am

Vinayakam Mani

are we checking any range here? if not, remove the above comment.

are we checking any range here? if not, remove the above comment.