dd-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 19
Total Committers: 14
Last Commit: 06:52
Commits this week: 19

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 17 Apr
9:54 am

Vinayakam Mani

Thursday 16 Apr
11:17 pm

Sean Nash and Vinayakam Mani

11:13 pm

Sean Nash

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
5:04 pm

Vendor - TEL - Sameer Poyil

4:23 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
4:19 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./AlarmMgmtSWFaults.h
    • -2
    • +2
    ./FpgaDD.c
    • -2
    • +2
    ./Messaging.c
  4. … 6 more files in changeset.
4:13 pm

Vendor - TEL - Sameer Poyil

LDT-2004 merging staging branch to LDT-2004-dialysate-composition-dosing-control--dd

Options
    • -5
    • +7
    ./AlarmMgmtSWFaults.h
    • -1180
    • +390
    ./FpgaDD.c
    • -19
    • +14
    ./Messaging.c
  4. … 3 more files in changeset.
2:28 pm

Vendor - TEL - Sameer Poyil

Its static function and not used by external API to pass the wrong id.

Its static function and not used by external API to pass the wrong id.

8:24 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./FpgaDD.c
    • -2
    • +2
    ./Messaging.c
  3. … 4 more files in changeset.
8:15 am

Michael Garthwaite

Wednesday 15 Apr
9:34 pm

Vendor - TEL - Sameer Poyil

0.0F is made by Sean.

0.0F is made by Sean.

5:31 pm

Sean Nash and Vinayakam Mani

4:12 pm

Michael Garthwaite

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

3:37 pm

Vinayakam Mani

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

10:06 am

Michael Garthwaite

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow-CLEAN

Options
    • -2
    • +3
    ./Messaging.c
9:52 am

Michael Garthwaite

nope. removed.

nope. removed.

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

7:52 am

Michael Garthwaite

LDT-3218: code review comments

Options
    • -1
    • +1
    ./FpgaDD.c
  2. … 3 more files in changeset.
Tuesday 14 Apr
9:22 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./AlarmMgmtSWFaults.h
    • -2
    • +2
    ./Messaging.c
  3. … 11 more files in changeset.
7:47 pm

Sean Nash and Vendor - TEL - Sameer Poyil

7:28 pm

Vinayakam Mani

Same comment applies here (removing resetPIController).

Same comment applies here (removing resetPIController).

7:18 pm

Vinayakam Mani

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

7:14 pm

Vinayakam Mani

Maintain space after and before parenthesis across the file.

Maintain space after and before parenthesis across the file.

7:11 pm

Vinayakam Mani

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across th...

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

7:02 pm

Vinayakam Mani

Remove this comment.

Remove this comment.

6:58 pm

Vinayakam Mani

You may use getF32OverrideValue for consistency (across the file).

You may use getF32OverrideValue for consistency (across the file).

6:51 pm

Vinayakam Mani

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)