leahi-fwcommon

Clone Tools

Stats

Commits this week: 3
Total Committers: 14
Last Commit: 21 May
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Jul
1:07 pm

Sean Nash

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

1:05 pm

Sean Nash

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Thursday 02 Jul
2:05 pm

Sean Nash

Tuesday 30 Jun
1:46 pm

Vendor - TEL - Jashwant Gantyada

1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

1:17 pm

Sean Nash

10:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
Wednesday 24 Jun
2:52 pm

Vendor - TEL - Sameer Poyil

2:51 pm

Vendor - TEL - Jashwant Gantyada

2:28 pm

Vendor - TEL - Arpita Srivastava

please remove extra line

please remove extra line

2:26 pm

Vendor - TEL - Arpita Srivastava

Output is none

Output is none

2:23 pm

Vendor - TEL - Arpita Srivastava

Please add message id.

Please add message id.

2:22 pm

Vendor - TEL - Arpita Srivastava

Output is none

Output is none

2:21 pm

Vendor - TEL - Arpita Srivastava

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Monday 22 Jun
5:39 pm

Sean Nash

Can we restore this code?

Can we restore this code?

5:36 pm

Sean Nash

Remove FANS test.

Remove FANS test.

5:34 pm

Sean Nash

Remove.

Remove.

5:33 pm

Sean Nash

Move this to Messaging.c

Move this to Messaging.c

5:32 pm

Sean Nash

Remove. Replaced by generic confirmation functions and messages.

Remove. Replaced by generic confirmation functions and messages.

5:30 pm

Sean Nash

Remove this function - replaced by generic confirmation functions.

Remove this function - replaced by generic confirmation functions.

5:28 pm

Sean Nash

Remove this timer code and replace with getConfirmationRequestStatus() and, if status is Accepted, do confirmation code above. If status is Rejected or TimedOut, clear offRequestAwaitingUserConfirm...

Remove this timer code and replace with getConfirmationRequestStatus() and, if status is Accepted, do confirmation code above. If status is Rejected or TimedOut, clear offRequestAwaitingUserConfirmation flag.

5:24 pm

Sean Nash

Replace with request code above.

Replace with request code above.

5:23 pm

Sean Nash

Remove this function after you've moved what we need.

Remove this function after you've moved what we need.

5:23 pm

Sean Nash

No need for these elses.

No need for these elses.

5:22 pm

Sean Nash

Remove send function call.

Remove send function call.

5:22 pm

Sean Nash

Move this code inside if statement to handleOffButtonProcessing() where same if statement exists.

Move this code inside if statement to handleOffButtonProcessing() where same if statement exists.

5:21 pm

Sean Nash

No need to move else - not needed.

No need to move else - not needed.

5:20 pm

Sean Nash

Replace this send function call with addConfirmationRequest()

Replace this send function call with addConfirmationRequest()

5:19 pm

Sean Nash

Move this if down to handleOffButtonProcessing()

Move this if down to handleOffButtonProcessing()