Activity td-firmware/firmware/App/Controllers/AirPump.c

Tree
Accordion

Stats

Commits this week: 3

Total Committers:	6
Last Commit:	22 May
Commits this week:	3

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 26 May

10:34 am

Vendor - TEL - Varshini Nagabooshanam

Friday 22 May

2:50 pm

Dara Navaei

More
41b0607
changed 5 files
LDT-2240-disposable-tube-set-self-test, LDT-3259-software-update---td-firmware and 5 more LEAHI-TD-FIRMWARE-LDT-2240-1 LEAHI-TD-FIRMWARE-LDT-4033-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./AirPump.c
- History
- Source
- Diff
./AirPump.c
… 4 more files in changeset.

12:22 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-3215-1
resumed reviewing

Thursday 21 May

11:22 am

Vendor - TEL - Varshini Nagabooshanam

More
07904e7
changed 5 files
LDT-2240-disposable-tube-set-self-test, LDT-3215-measured-venous-pressure-decreases and 6 more LEAHI-TD-FIRMWARE-LDT-3215-1

LDT-3215-measured-venous-pressure-decreases

- -10
- +39
./AirPump.c
- History
- Source
- Diff
./AirPump.c
… 4 more files in changeset.

Tuesday 14 Apr

5:30 pm

Vendor - TEL - Varshini Nagabooshanam

More
LEAHI-TD-FIRMWARE-LDT-3215-1
started review

LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed

LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed

9:49 am

Vendor - TEL - Jashwant Gantyada

More
LEAHI-TD-FIRMWARE-LDT-3215-1
joined review

Thursday 19 Mar

9:12 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:12 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

9:11 am

Vendor - TEL - Varshini Nagabooshanam

More
9d4aa5a
changed 1 file
LDT-2240-disposable-tube-set-self-test, LDT-3215-measured-venous-pressure-decreases and 6 more LEAHI-TD-FIRMWARE-LDT-3215-1

LDT-3215-measured-venous-pressure-decreases

- -16
- +12
./AirPump.c
- History
- Source
- Diff
./AirPump.c

Tuesday 17 Mar

9:46 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

9:44 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
replied to Vendor - TEL - Varshini Nagabooshanam

I was thinking that comment should go above the first if statement.

I was thinking that comment should go above the first if statement.

3:05 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

3:05 pm

Vendor - TEL - Varshini Nagabooshanam

More
02f3bf1
changed 1 file
LDT-2240-disposable-tube-set-self-test, LDT-3215-measured-venous-pressure-decreases and 6 more LEAHI-TD-FIRMWARE-LDT-3215-1

LDT-3215-measured-venous-pressure-decreases

- -2
- +3
./AirPump.c
- History
- Source
- Diff
./AirPump.c

2:56 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below: #define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall con...

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

2:56 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

More
ff6e2f4
changed 1 file
LDT-2240-disposable-tube-set-self-test, LDT-3215-measured-venous-pressure-decreases and 6 more LEAHI-TD-FIRMWARE-LDT-3215-1

LDT-3215-measured-venous-pressure-decreases

- -0
- +1
./AirPump.c
- History
- Source
- Diff
./AirPump.c

2:53 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

More
8ded3ec
changed 1 file
LDT-2240-disposable-tube-set-self-test, LDT-3215-measured-venous-pressure-decreases and 6 more LEAHI-TD-FIRMWARE-LDT-3215-1

LDT-3215-measured-venous-pressure-decreases

- -0
- +1
./AirPump.c
- History
- Source
- Diff
./AirPump.c

2:50 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Should probably initialize your new stall counter variable.

Should probably initialize your new stall counter variable.

2:11 pm

Vendor - TEL - Varshini Nagabooshanam

More
Re: LEAHI-TD-FIRMWARE-LDT-3215-1
commented on review

Sean Nash I need your help for writing this Alarm properties.

Sean Nash I need your help for writing this Alarm properties.

2:02 pm

Vendor - TEL - Varshini Nagabooshanam

More
80f6d7e
changed 1 file
LDT-2240-disposable-tube-set-self-test, LDT-3215-measured-venous-pressure-decreases and 6 more LEAHI-TD-FIRMWARE-LDT-3215-1

LDT-3215-measured-venous-pressure-decreases

- -0
- +33
./AirPump.c
- History
- Source
- Diff
./AirPump.c

Wednesday 04 Mar

8:22 pm

Vendor - TEL - Sameer Poyil

Monday 02 Mar

9:01 pm

Dara Navaei

More
c049177
changed 9 files
LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td-baro and 34 more LEAHI-TD-FIRMWARE-LDT-3215-1 LEAHI-TD-FIRMWARE-LDT-1394-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./AirPump.c
- History
- Source
- Diff
./AirPump.c
… 8 more files in changeset.

8:46 pm

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-1903-8
resumed reviewing

11:54 am

Vendor - TEL - Sameer Poyil

fixed in latest code

fixed in latest code

11:53 am

Vendor - TEL - Sameer Poyil

implemented

implemented

11:53 am

Vendor - TEL - Sameer Poyil

fixed

fixed

11:41 am

Vendor - TEL - Sameer Poyil

More
c70a435
changed 3 files
LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td-baro and 34 more LEAHI-TD-FIRMWARE-LDT-1903-8

LDT-1903 Air Trap adding duty cycle out of range software fault alarm

- -1
- +1
./AirPump.c
- History
- Source
- Diff
./AirPump.c
… 2 more files in changeset.

11:13 am

Vendor - TEL - Sameer Poyil

More
bcb2d06
changed 1 file
LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td-baro and 34 more LEAHI-TD-FIRMWARE-LDT-1903-8

LDT-1903 Air Trap adding duty cycle out of range alarm

- -0
- +1
./AirPump.c
- History
- Source
- Diff
./AirPump.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-05-28 11:23 -0700