td-firmware / firmware / App

Drivers

Clone Tools

Stats

Commits this week: 7
Total Committers: 8
Last Commit: 22 May
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 May
5:13 pm

Sean Nash

Not a float.

Not a float.

5:12 pm

Sean Nash

Not a float.

Not a float.

5:12 pm

Sean Nash

Not a float anymore. Use u32Override function and no need to cast the pointer.

Not a float anymore. Use u32Override function and no need to cast the pointer.

5:07 pm

Sean Nash

Should we publish all registers read?

Should we publish all registers read?

5:05 pm

Sean Nash

Remove this comment since we have a comment to right.

Remove this comment since we have a comment to right.

5:04 pm

Sean Nash

Remove comment.

Remove comment.

5:00 pm

Sean Nash

REG_ADDRESSES

REG_ADDRESSES

5:00 pm

Sean Nash

DEVICE_ADDRESSES

DEVICE_ADDRESSES

4:59 pm

Sean Nash

Set them individually instead of with memset.

Set them individually instead of with memset.

4:56 pm

Sean Nash

Add blank line before a /// comment.

Add blank line before a /// comment.

4:55 pm

Sean Nash

device and register is fine. Or deviceSel and registerSel.

device and register is fine. Or deviceSel and registerSel.

4:42 pm

Vendor - TEL - Arpita Srivastava

Which alarm?

Which alarm?

4:42 pm

Vendor - TEL - Arpita Srivastava

bpPublishTimerCtr is the output?

bpPublishTimerCtr is the output?

4:40 pm

Vendor - TEL - Arpita Srivastava

Input is none. Add @Alarms

Input is none.
Add @Alarms

4:38 pm

Vendor - TEL - Arpita Srivastava

Should we list the alarm ids? @Alarms?

Should we list the alarm ids? @Alarms?

4:36 pm

Vendor - TEL - Arpita Srivastava

requestAbortBPReading is the output?

requestAbortBPReading is the output?

4:36 pm

Vendor - TEL - Arpita Srivastava

requestPedsBPReading is the output?

requestPedsBPReading is the output?

4:35 pm

Vendor - TEL - Arpita Srivastava

requestAdultBPReading is the output?

requestAdultBPReading is the output?

4:35 pm

Vendor - TEL - Arpita Srivastava

pendingVitalsRequest is the output?

pendingVitalsRequest is the output?

4:34 pm

Vendor - TEL - Arpita Srivastava

We should initialize in the init function?

We should initialize in the init function?

4:31 pm

Vendor - TEL - Arpita Srivastava

bpMeasurementReady is an output?

bpMeasurementReady is an output?

4:29 pm

Vendor - TEL - Arpita Srivastava

nextState is the return value. Should we add requestAdultBPMeasurement, bpMeasurementReady and bpDriverError to outputs?

nextState is the return value.
Should we add requestAdultBPMeasurement, bpMeasurementReady and bpDriverError to outputs?

4:24 pm

Vendor - TEL - Arpita Srivastava

Where are we updating the bpResults?

Where are we updating the bpResults?

4:22 pm

Vendor - TEL - Arpita Srivastava

We should initialize this in init functions.

We should initialize this in init functions.

4:22 pm

Vendor - TEL - Arpita Srivastava

please add a comment

please add a comment

4:18 pm

Vendor - TEL - Arpita Srivastava

pressure is a param?

pressure is a param?

4:18 pm

Vendor - TEL - Arpita Srivastava

command is a param?

command is a param?

3:21 pm

Sean Nash

Move to driver.

Move to driver.

3:21 pm

Sean Nash

Recommend command be a U08 here. Driver should have the enum and pass the enum to this function. FPGA should just take a byte.

Recommend command be a U08 here. Driver should have the enum and pass the enum to this function. FPGA should just take a byte.

3:09 pm

Sean Nash

Move publish call from exec to the check state handle function.

Move publish call from exec to the check state handle function.