td-firmware / firmware / App / Modes

ModePreTreat.h

Clone Tools

Stats

Commits this week: 3
Total Committers: 4
Last Commit: 22 May
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 22 May
3:39 pm

Vendor - TEL - Praneeth Bunne

1:31 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

Wednesday 20 May
3:49 pm

Vendor - TEL - Arpita Srivastava

We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

12:14 pm

Sean Nash

Is this the right time to zero this volume?

Is this the right time to zero this volume?

12:13 pm

Sean Nash

update total volume too?

update total volume too?

12:09 pm

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

11:41 am

Sean Nash

Use #define for array size.

Use #define for array size.

11:40 am

Sean Nash

Make the 6 a #define

Make the 6 a #define

11:39 am

Sean Nash

only 1 return statement

only 1 return statement

11:35 am

Sean Nash

remove comma

remove comma

11:24 am

Sean Nash

return FALSE on else

return FALSE on else

11:24 am

Sean Nash

signal functions should return BOOL.

signal functions should return BOOL.

11:20 am

Sean Nash

Move up with rest

Move up with rest

11:17 am

Sean Nash

Move this function to your service.

Move this function to your service.

11:16 am

Sean Nash

Add HDF state too

Add HDF state too

11:09 am

Sean Nash

Not needed.

Not needed.

11:06 am

Sean Nash

Should always exec your bolus sm.

Should always exec your bolus sm.

11:01 am

Sean Nash

Keep 2 blank lines before banner

Keep 2 blank lines before banner

10:59 am

Sean Nash

Add fluid bolus state

Add fluid bolus state

10:59 am

Sean Nash

Add fluid bolus state

Add fluid bolus state

10:58 am

Sean Nash

FLUID_BOLUS_CMD_EVENT

FLUID_BOLUS_CMD_EVENT

Tuesday 19 May
5:39 pm

Sean Nash

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

5:37 pm

Sean Nash

Remove this blank line.

Remove this blank line.

3:37 pm

Vendor - TEL - Arpita Srivastava

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

3:35 pm

Sean Nash

This merge conflict is still unresolved.

This merge conflict is still unresolved.

3:35 pm

Vendor - TEL - Arpita Srivastava

leak in the comment section.

leak in the comment section.

3:34 pm

Sean Nash

Where is alarm 191..203?

Where is alarm 191..203?

Monday 18 May
9:45 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

9:44 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Friday 15 May
9:52 am

Vendor - TEL - Varshini Nagabooshanam

I missed updating this earlier, I’ll push the updated code.

I missed updating this earlier, I’ll push the updated code.