td-firmware / firmware / App / Modes

ModeTreatment.h

Clone Tools

Stats

Commits this week: 3
Total Committers: 5
Last Commit: 22 May
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 May
1:22 pm

Sean Nash

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

1:07 pm

Sean Nash

Add a doxygen comment above this array.

Add a doxygen comment above this array.

1:06 pm

Sean Nash

Add a doxygen comment above this array (similar to structures).

Add a doxygen comment above this array (similar to structures).

1:04 pm

Sean Nash

Add a doxygen comment above structure for the whole structure (see structure above for example).

Add a doxygen comment above structure for the whole structure (see structure above for example).

1:03 pm

Sean Nash

Add a doxygen comment for this definition.

Add a doxygen comment for this definition.

Tuesday 26 May
11:30 am

Raghu Kallala

remove camel case for SetPoint, instead use Setpoint Update line 659 too

remove camel case for SetPoint, instead use Setpoint
Update line 659 too

11:15 am

Vendor - TEL - Arpita Srivastava

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

11:14 am

Vendor - TEL - Arpita Srivastava

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

11:10 am

Vendor - TEL - Arpita Srivastava

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

11:09 am

Vendor - TEL - Arpita Srivastava

Looks like comment for 208 and 223 are swapped?

Looks like comment for 208 and 223 are swapped?

11:07 am

Vendor - TEL - Arpita Srivastava

please align the comments

please align the comments

10:36 am

Vendor - TEL - Arpita Srivastava

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

10:34 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines and check other functions too.

Please break it into two lines and check other functions too.

10:30 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:30 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:27 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

Please break it into two lines
Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

10:22 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:21 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:15 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:15 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:13 am

Vendor - TEL - Arpita Srivastava

TREAT_PARAMS_PROPERTIES should also be an input?

TREAT_PARAMS_PROPERTIES should also be an input?

10:05 am

Vendor - TEL - Arpita Srivastava

please add @param

please add @param

10:04 am

Vendor - TEL - Arpita Srivastava

please align the comment

please align the comment

Sunday 17 May
11:46 pm

Sean Nash

Why was this function header changed? I think it was correct before.

Why was this function header changed? I think it was correct before.

11:37 pm

Sean Nash

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

Thursday 14 May
9:48 am

Vendor - TEL - Arpita Srivastava

Looks like the description part should only be in the @param part. sysConfigTreatmentParameters should be an output? Input is None. Add @details for alarms

Looks like the description part should only be in the @param part.
sysConfigTreatmentParameters should be an output? Input is None.
Add @details for alarms

9:29 am

Vendor - TEL - Arpita Srivastava

align comment

align comment

9:26 am

Vendor - TEL - Arpita Srivastava

The Id name looks too long? What if we change Temperature to Temp?

The Id name looks too long? What if we change Temperature to Temp?

Tuesday 12 May
3:44 pm

Vendor - TEL - Arpita Srivastava

Please list names of variables in inputs and outputs. You can move any description in the brief section.

Please list names of variables in inputs and outputs.
You can move any description in the brief section.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment for this check and break the line in two lines.

Please add a comment for this check and break the line in two lines.