td-firmware / firmware / App

Tasks

Clone Tools

Stats

Commits this week: 2
Total Committers: 7
Last Commit: 22 May
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 May
5:13 pm

Sean Nash

Not a float.

Not a float.

5:12 pm

Sean Nash

Not a float.

Not a float.

5:12 pm

Sean Nash

Not a float anymore. Use u32Override function and no need to cast the pointer.

Not a float anymore. Use u32Override function and no need to cast the pointer.

5:07 pm

Sean Nash

Should we publish all registers read?

Should we publish all registers read?

5:05 pm

Sean Nash

Remove this comment since we have a comment to right.

Remove this comment since we have a comment to right.

5:04 pm

Sean Nash

Remove comment.

Remove comment.

5:00 pm

Sean Nash

REG_ADDRESSES

REG_ADDRESSES

5:00 pm

Sean Nash

DEVICE_ADDRESSES

DEVICE_ADDRESSES

4:59 pm

Sean Nash

Set them individually instead of with memset.

Set them individually instead of with memset.

4:56 pm

Sean Nash

Add blank line before a /// comment.

Add blank line before a /// comment.

4:55 pm

Sean Nash

device and register is fine. Or deviceSel and registerSel.

device and register is fine. Or deviceSel and registerSel.

Thursday 21 May
4:27 pm

Vendor - TEL - Arpita Srivastava

3:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

Wednesday 20 May
4:23 pm

Sean Nash

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

4:22 pm

Sean Nash

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

4:20 pm

Sean Nash

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

2:12 pm

Vendor - TEL - Jashwant Gantyada

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

2:07 pm

Vendor - TEL - Arpita Srivastava

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

1:59 pm

Vendor - TEL - Arpita Srivastava

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

12:14 pm

Sean Nash

Is this the right time to zero this volume?

Is this the right time to zero this volume?

12:13 pm

Sean Nash

update total volume too?

update total volume too?

12:09 pm

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

11:41 am

Sean Nash

Use #define for array size.

Use #define for array size.

11:40 am

Sean Nash

Make the 6 a #define

Make the 6 a #define

11:39 am

Sean Nash

only 1 return statement

only 1 return statement

11:35 am

Sean Nash

remove comma

remove comma

11:24 am

Sean Nash

return FALSE on else

return FALSE on else

11:24 am

Sean Nash

signal functions should return BOOL.

signal functions should return BOOL.

11:20 am

Sean Nash

Move up with rest

Move up with rest

11:17 am

Sean Nash

Move this function to your service.

Move this function to your service.