td-firmware / firmware / App

TDCommon.h

Clone Tools

Stats

Commits this week: 5
Total Committers: 8
Last Commit: 18 Jun
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Jul
1:07 pm

Sean Nash

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

1:05 pm

Sean Nash

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Thursday 02 Jul
1:19 pm

Vendor - TEL - Varshini Nagabooshanam

12:33 pm

Dara Navaei and Sean Nash

12:31 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, Fixed

Yes, Fixed

12:30 pm

Vendor - TEL - Varshini Nagabooshanam

For testing purpose, Since UI board had old build so it was throwing the alarms

For testing purpose, Since UI board had old build so it was throwing the alarms

12:27 pm

Dara Navaei

I see in the commits that you commented this #define was that on purpose?

I see in the commits that you commented this #define was that on purpose?

12:25 pm

Dara Navaei

Per our coding standards, it should be "0 == currentAirPumpRPM".

Per our coding standards, it should be "0 == currentAirPumpRPM".

Wednesday 01 Jul
10:00 am

Vendor - TEL - Varshini Nagabooshanam

Yes removed

Yes removed

10:00 am

Vendor - TEL - Varshini Nagabooshanam

Agree! Fixed

Agree! Fixed

9:48 am

Sean Nash

I don't think this is needed. You can't get to this else until the delay counter reaches this count.

I don't think this is needed. You can't get to this else until the delay counter reaches this count.

9:42 am

Sean Nash

Is this necessary? Treatment paused state will do this.

Is this necessary? Treatment paused state will do this.

9:39 am

Sean Nash

Tuesday 30 Jun
1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Monday 29 Jun
7:45 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4875_(TD) H12 is not Actuating during AT Lower and Raise Events
LEAHI-TD-FIRMWARE-LDT-4875_(TD) H12 is not Actuating during AT Lower and Raise Events
Wednesday 17 Jun
12:04 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
Friday 12 Jun
5:40 pm

Vinayakam Mani

Bubble status, Low and high level level sensors.

Bubble status, Low and high level level sensors.

5:39 pm

Vinayakam Mani

Input : Blood pump door status?

Input : Blood pump door status?

5:27 pm

Vinayakam Mani

To be restored?

To be restored?

5:24 pm

Vinayakam Mani

Are these being initialized in the init function?

Are these being initialized in the init function?

5:16 pm

Vinayakam Mani

Need to resolve the merge issues?

Need to resolve the merge issues?

2:27 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
Thursday 11 Jun
10:29 pm

Vendor - TEL - Praneeth Bunne

Friday 05 Jun
10:30 am

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
10:08 am

Sean Nash

Thursday 04 Jun
9:52 am

Vendor - TEL - Jashwant Gantyada

9:00 am

Sean Nash

Should this check be moved to the fluid bolus exec function?

Should this check be moved to the fluid bolus exec function?

Wednesday 03 Jun
12:29 pm

Vinayakam Mani

9:51 am

Sean Nash

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD...

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.