td-firmware / firmware

source

Clone Tools

Stats

Commits this week: 3
Total Committers: 4
Last Commit: 11 May
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
5 hrs ago

Sean Nash

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

5 hrs ago

Sean Nash

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

5 hrs ago

Sean Nash

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

7 hrs ago

Vendor - TEL - Jashwant Gantyada

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

7 hrs ago

Vendor - TEL - Arpita Srivastava

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

7 hrs ago

Vendor - TEL - Arpita Srivastava

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

11 hrs ago

Sean Nash

slaveAddr should be an enum now and so just "device".

slaveAddr should be an enum now and so just "device".

12 hrs ago

Sean Nash

Add a banner before Dialin test support functions (see other units for example).

Add a banner before Dialin test support functions (see other units for example).

12 hrs ago

Sean Nash

Initialize .override to OVERRIDE_RESET

Initialize .override to OVERRIDE_RESET

12 hrs ago

Sean Nash

Why is this commented out? Do we not need to initialize it?

Why is this commented out? Do we not need to initialize it?

Tuesday 19 May
2:33 pm

Sean Nash

2:30 pm

Sean Nash

Align comment.

Align comment.

2:24 pm

Sean Nash

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.

2:20 pm

Sean Nash

Should this line be un-commented?

Should this line be un-commented?

2:19 pm

Sean Nash

So we are going to fail this test until calibration record is ready?

So we are going to fail this test until calibration record is ready?

2:16 pm

Sean Nash

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

9:27 am

Sean Nash

Rename similar to ADDR definitions below. these are not commands.

Rename similar to ADDR definitions below. these are not commands.

9:14 am

Sean Nash

Combine charger and pack data into one payload with one broadcast message.

Combine charger and pack data into one payload with one broadcast message.

9:12 am

Sean Nash

Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.

Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.

9:11 am

Sean Nash

I think we only need one data message for both charger and battery pack data.

I think we only need one data message for both charger and battery pack data.

9:09 am

Sean Nash

Remove.

Remove.

9:09 am

Sean Nash

uncomment.

uncomment.

Friday 15 May
6:12 pm

Sean Nash

Call the init for the battery driver here.

Call the init for the battery driver here.

6:11 pm

Sean Nash

INVALID_BATTERY

INVALID_BATTERY

5:52 pm

Sean Nash

Remove repeating entries.

Remove repeating entries.

5:49 pm

Sean Nash

remove extra blank line.

remove extra blank line.

5:48 pm

Sean Nash

Remove this comment.

Remove this comment.

5:48 pm

Sean Nash

Remove blank line.

Remove blank line.

5:47 pm

Sean Nash

initialize all of these in init function.

initialize all of these in init function.

5:47 pm

Sean Nash

Missing doxygen group

Missing doxygen group