dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 21
Total Committers: 20
Last Commit: 15:49
Commits this week: 21

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Vendor - TEL - Jashwant Gantyada

LDT-4024 reduced heater target temp for testing

Options
    • -5
    • +11
    ./Modes/ModeHeatDisinfect.c
2 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-4024 addressed code review comments

Options
    • -6
    • +20
    ./Modes/ModeHeatDisinfect.c
    • -8
    • +0
    ./Modes/ModeHeatDisinfect.h
3 hrs ago

Michael Garthwaite

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

4 hrs ago

Vinayakam Mani

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

6 hrs ago

Vinayakam Mani

Add D92 pump On at 50ml/min.

Add D92 pump On at 50ml/min.

6 hrs ago

Vinayakam Mani

Remove D95 from closed state and add D88 to closed state.

Remove D95 from closed state and add D88 to closed state.

6 hrs ago

Vinayakam Mani

D35, D40, D34,D91,D95 : Open M12, P39 : Closed ( keep a TODO comment to remove them later)

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)

6 hrs ago

Vinayakam Mani

close D80, D64, D14?

close D80, D64, D14?

6 hrs ago

Vinayakam Mani

D80 : open, D65: Close?

D80 : open, D65: Close?

8 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-4024 base implementation for heat disinfection

Options
    • -0
    • +1136
    ./Modes/ModeHeatDisinfect.c
    • -0
    • +53
    ./Modes/ModeHeatDisinfect.h
8 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-4024 base implementation for heat disinfection

Options
    • -6
    • +6
    ./Modes/OperationModes.c
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
Tuesday 18 Aug
11:39 am

Sean Nash

I'm seeing a lot of magic numbers. We should have #defines for these values.

I'm seeing a lot of magic numbers. We should have #defines for these values.

11:37 am

Sean Nash

Add doxygen comments to right.

Add doxygen comments to right.

Monday 17 Aug
4:59 pm

Sean Nash

10:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
10:12 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
7:45 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4022_Disinfection (DD heat, heat+descale) - FW Implementation - 1/4:
LEAHI-DD-FIRMWARE-LDT-4022_Disinfection (DD heat, heat+descale) - FW Implementation - 1/4:
Friday 14 Aug
10:36 am

Vendor - TEL - Sameer Poyil

The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

10:25 am

Vendor - TEL - Sameer Poyil

removed

removed

10:25 am

Vendor - TEL - Sameer Poyil

updated

updated

10:02 am

Vendor - TEL - Sameer Poyil

updated

updated

10:01 am

Vendor - TEL - Sameer Poyil

updated

updated

10:00 am

Vendor - TEL - Sameer Poyil

removed

removed

Wednesday 12 Aug
3:59 pm

Sean Nash

Are we done testing? Can we remote test variables and code?

Are we done testing? Can we remote test variables and code?

3:29 pm

Vinayakam Mani

Remove Sequence step states if not being used.

Remove Sequence step states if not being used.

3:27 pm

Vinayakam Mani

Update comments ( remove start/end states)

Update comments ( remove start/end states)

3:26 pm

Vinayakam Mani

Update TD to DD.

Update TD to DD.

3:26 pm

Vinayakam Mani

Update alarm properties (DD fault, Priority eti,.)

Update alarm properties (DD fault, Priority eti,.)

3:23 pm

Vinayakam Mani

Remove the empty line.

Remove the empty line.

3:20 pm

Vinayakam Mani

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?