dd-firmware / firmware / App / Modes / FPModes

FPModeStandby.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 19 Aug
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 19 Aug
1:40 pm

Michael Garthwaite

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

Monday 17 Aug
4:59 pm

Sean Nash

Tuesday 11 Aug
10:18 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
Thursday 06 Aug
9:21 am

Vendor - TEL - Suresh Dharnala

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the inte...

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

9:13 am

Vendor - TEL - Suresh Dharnala

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic plac...

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic placeholder for the sampling mode/state and update the implementation and requirements once the feature is better defined.

Monday 03 Aug
11:05 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
Monday 27 Jul
2:22 pm

Vinayakam Mani

you need to bring in the new set of valves here as well.

you need to bring in the new set of valves here as well.

2:21 pm

Vinayakam Mani

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

2:15 pm

Vinayakam Mani

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode b...

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

1:43 pm

Vinayakam Mani

Align the indent. Replace RO to FP.

Align the indent. Replace RO to FP.

Monday 29 Jun
10:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2:
Wednesday 24 Jun
6:36 am

Raghu Kallala

Wednesday 06 May
8:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Thursday 02 Apr
7:13 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./FPModeStandby.c
  2. … 16 more files in changeset.
7:11 am

Raghu Kallala

7:11 am

Raghu Kallala

Wednesday 01 Apr
12:26 pm

Vinayakam Mani , Michael Garthwaite and Sean Nash

Tuesday 31 Mar
10:26 am

Raghu Kallala

Updated

Updated

10:17 am

Raghu Kallala

Added

Added

9:43 am

Sean Nash

Add a comment: result already FALSE - do nothing more for modes that do not support jump to sub-mode.

Add a comment:
result already FALSE - do nothing more for modes that do not support jump to sub-mode.

9:42 am

Sean Nash

Add a comment here: Do nothing for modes that do not support jump to sub-mode.

Add a comment here:
Do nothing for modes that do not support jump to sub-mode.

7:46 am

Raghu Kallala

LDT-3603 addressed review comments

Options
    • -1
    • +1
    ./FPModeStandby.c
  2. … 6 more files in changeset.
7:04 am

Raghu Kallala

Updated

Updated

7:04 am

Raghu Kallala

Updated, thanks

Updated, thanks

Monday 30 Mar
4:58 pm

Michael Garthwaite and Vinayakam Mani

4:56 pm

Vinayakam Mani

'genPermeateState' in the outputs. please update across the files as needed.

'genPermeateState' in the outputs. please update across the files as needed.

4:35 pm

Vinayakam Mani

Validates the requested sub mode change is acceptable or not?

Validates the requested sub mode change is acceptable or not?

1:46 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem
LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem
1:43 pm

Raghu Kallala

LDT-3603 redo of FP set operation sub mode on a new branch

Options
    • -0
    • +52
    ./FPModeStandby.c
  2. … 16 more files in changeset.
Wednesday 18 Mar
2:30 pm

Sean Nash and Michael Garthwaite