TDCommon.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 14 more files in changeset.
Yes, Fixed

Yes, Fixed

For testing purpose, Since UI board had old build so it was throwing the alarms

For testing purpose, Since UI board had old build so it was throwing the alarms

I see in the commits that you commented this #define was that on purpose?

I see in the commits that you commented this #define was that on purpose?

Per our coding standards, it should be "0 == currentAirPumpRPM".

Per our coding standards, it should be "0 == currentAirPumpRPM".

Fixes

Merge branch 'staging' of bitbucket.org:diality-cloud/td-firmware into LDT-4875-td-h12-is-not-actuating-during

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Fixes

Yes removed

Yes removed

Agree! Fixed

Agree! Fixed

I don't think this is needed. You can't get to this else until the delay counter reaches this count.

I don't think this is needed. You can't get to this else until the delay counter reaches this count.

Is this necessary? Treatment paused state will do this.

Is this necessary? Treatment paused state will do this.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

LEAHI-TD-FIRMWARE-LDT-4875_(TD) H12 is not Actuating during AT Lower and Raise Events
LEAHI-TD-FIRMWARE-LDT-4875_(TD) H12 is not Actuating during AT Lower and Raise Events
Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Bubble status, Low and high level level sensors.

Bubble status, Low and high level level sensors.

Input : Blood pump door status?

Input : Blood pump door status?

To be restored?

To be restored?

Are these being initialized in the init function?

Are these being initialized in the init function?

Need to resolve the merge issues?

Need to resolve the merge issues?

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.