td-firmware / firmware / App / Controllers

Valves.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 4
Last Commit: 14 Jul
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 14 Jul
11:17 pm

Sean Nash

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

11:10 pm

Sean Nash

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

5:53 pm

Sean Nash

171

171

Monday 13 Jul
1:47 pm

Sean Nash

Who is calling this function? Should be coming from UI, right? So should be a message handler (returns BOOL, takes a message as param, function is in table at top of Messaging.c).

Who is calling this function? Should be coming from UI, right? So should be a message handler (returns BOOL, takes a message as param, function is in table at top of Messaging.c).

1:22 pm

Sean Nash

Need to set state to preload state I think. Otherwise you will go to interrupted state.

Need to set state to preload state I think. Otherwise you will go to interrupted state.

12:44 pm

Sean Nash

Why did you remote call to init function here? Is it initialized somewhere else?

Why did you remote call to init function here? Is it initialized somewhere else?

12:41 pm

Sean Nash

Use ternary operation to assign TRUE or FALSE explicitly.

Use ternary operation to assign TRUE or FALSE explicitly.

12:39 pm

Sean Nash

This is at end of enum list above. So it should be at end of table here.

This is at end of enum list above. So it should be at end of table here.

Thursday 09 Jul
2:07 pm

Sean Nash

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

1:36 pm

Sean Nash

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

1:32 pm

Sean Nash

I believe the SyringePump controller will trigger this alarm at end of seek operation.

I believe the SyringePump controller will trigger this alarm at end of seek operation.

1:28 pm

Sean Nash

Syringe pump should already be stopped if preload is done. Do we need to call this here?

Syringe pump should already be stopped if preload is done. Do we need to call this here?

1:24 pm

Sean Nash

This is called from preload state. Not needed here I think.

This is called from preload state. Not needed here I think.

1:22 pm

Sean Nash

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

1:20 pm

Sean Nash

Why (void)?

Why (void)?

1:16 pm

Sean Nash

Where is this being called? Should be called from pre-treatment init I think.

Where is this being called? Should be called from pre-treatment init I think.

1:11 pm

Sean Nash

Why are we signaling syringe load confirmed here?

Why are we signaling syringe load confirmed here?

1:11 pm

Sean Nash

Do these states need to be public?

Do these states need to be public?

1:08 pm

Sean Nash

Move up one row to alphabetize.

Move up one row to alphabetize.

Thursday 02 Jul
1:47 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4029_Pre-Treatment - FW Implementation - 4/6:
LEAHI-TD-FIRMWARE-LDT-4029_Pre-Treatment - FW Implementation - 4/6:
10:10 am

Sean Nash

10:05 am

Vendor - TEL - Varshini Nagabooshanam

Wednesday 01 Jul
10:28 pm

Dara Navaei

9:32 am

Sean Nash

Monday 04 May
7:01 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4248_(TD) RO Loop Testing / Demo: TD pinch valves to be in the correct state at standby and treatment
LEAHI-TD-FIRMWARE-LDT-4248_(TD) RO Loop Testing / Demo: TD pinch valves to be in the correct state at standby and treatment
Friday 19 Dec 2025
1:57 pm

Dara Navaei

12:16 pm

Vendor - TEL - Sameer Poyil and Sean Nash

Thursday 18 Dec 2025
3:08 pm

Dara Navaei

We tend to initialize the local variables as a standard practice.

We tend to initialize the local variables as a standard practice.

2:54 pm

Sean Nash

These don't need to be initialized to zero.

These don't need to be initialized to zero.

Wednesday 17 Dec 2025
11:07 am

Dara Navaei

Done

Done