td-firmware / firmware / App / Services / StateServices

TubeSetAutoEject.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 2
Last Commit: 12 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Jun
2:47 pm

Vendor - TEL - Jashwant Gantyada , Vendor - TEL - Arpita Srivastava and Sean Nash

11:36 am

Vendor - TEL - Arpita Srivastava

Thank you for the clarification!

Thank you for the clarification!

11:33 am

Vendor - TEL - Arpita Srivastava

break into two lines

break into two lines

11:32 am

Vendor - TEL - Arpita Srivastava

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG

11:27 am

Vendor - TEL - Arpita Srivastava

Add newAlarmIndicateStop to output

Add newAlarmIndicateStop to output

11:21 am

Vendor - TEL - Arpita Srivastava

Add newAlarmIndicateStop to input and output.

Add newAlarmIndicateStop to input and output.

Friday 12 Jun
11:04 pm

Sean Nash

Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.

Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.

3:50 pm

Vendor - TEL - Arpita Srivastava

pauseBolusResumeState is input

pauseBolusResumeState is input

3:47 pm

Vendor - TEL - Arpita Srivastava

add alarm

add alarm

3:46 pm

Vendor - TEL - Arpita Srivastava

Replace // to ///< for line 56 to 60

Replace // to ///< for line 56 to 60

3:27 pm

Sean Nash

3:06 pm

Sean Nash

Use // comments for function prototypes.

Use // comments for function prototypes.

3:06 pm

Sean Nash

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

3:05 pm

Sean Nash

These were fine (and preferred) as // because doxygen gets function details from function headers in the .c file.

These were fine (and preferred) as // because doxygen gets function details from function headers in the .c file.

9:32 am

Sean Nash

Should we be looking at tubing set type instead of modality here?

Should we be looking at tubing set type instead of modality here?

9:28 am

Sean Nash

Can we not determine this now? Why TODO?

Can we not determine this now? Why TODO?

9:27 am

Sean Nash

Shouldn't we be checking tubing set type instead of modality here?

Shouldn't we be checking tubing set type instead of modality here?

9:23 am

Sean Nash

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

9:22 am

Sean Nash

Initialize to UNKNOWN type. Remove TODO.

Initialize to UNKNOWN type. Remove TODO.

9:21 am

Sean Nash

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

9:18 am

Sean Nash

Use /// when above, use ///< when to the right. Also remove extra space before Tube

Use /// when above, use ///< when to the right.
Also remove extra space before Tube

9:17 am

Sean Nash

Change // to ///<

Change // to ///<

4:02 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
Friday 22 May
3:39 pm

Vendor - TEL - Praneeth Bunne

1:31 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

11:47 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -3
    • +3
    ./TubeSetAutoEject.h
  2. … 14 more files in changeset.
Wednesday 20 May
3:49 pm

Vendor - TEL - Arpita Srivastava

We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

Tuesday 19 May
3:37 pm

Vendor - TEL - Arpita Srivastava

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

3:35 pm

Sean Nash

This merge conflict is still unresolved.

This merge conflict is still unresolved.

3:35 pm

Vendor - TEL - Arpita Srivastava

leak in the comment section.

leak in the comment section.