FpgaTD.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
If this reserved2 is a U32, next register would be at 288 (not 285). Should we make reserved2 a U08?

If this reserved2 is a U32, next register would be at 288 (not 285). Should we make reserved2 a U08?

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Do we still need this?

Do we still need this?

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

this function should not return anything.

this function should not return anything.

Please rename all the sPump registers as h10 for consistency.

Please rename all the sPump registers as h10 for consistency.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Fixed

Fixed

Added

Added

Fixed

Fixed

Fixed

Fixed

Fixed

Fixed

Not required here since we are initializing in the main

Not required here since we are initializing in the main

Yes removed

Yes removed

Fixed

Fixed

Fixed

Fixed

fpgaActuatorSetPoints is an output. Input is none.

fpgaActuatorSetPoints is an output.
Input is none.

Include "BPModule.h".

Include "BPModule.h".

BPModule is just one of the controllers - move this up into the controllers section.

BPModule is just one of the controllers - move this up into the controllers section.

We should not comment this out.

We should not comment this out.

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

We are already executing this from TaskGeneral.c. Remove from here.

We are already executing this from TaskGeneral.c. Remove from here.

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

I think all flags are outputs (not just adult).

I think all flags are outputs (not just adult).

These look like outputs to me (not inputs).

These look like outputs to me (not inputs).

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 7 more files in changeset.