ModeStandby.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 10 more files in changeset.
I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

maybe use target rate for both.

maybe use target rate for both.

Use #define for array size.

Use #define for array size.

Make the 6 a #define

Make the 6 a #define

only 1 return statement

only 1 return statement

remove comma

remove comma

signal functions should return BOOL.

signal functions should return BOOL.

Move up with rest

Move up with rest

Move this function to your service.

Move this function to your service.

Not needed.

Not needed.

Should always exec your bolus sm.

Should always exec your bolus sm.

Keep 2 blank lines before banner

Keep 2 blank lines before banner

Add fluid bolus state

Add fluid bolus state

Add fluid bolus state

Add fluid bolus state

Align comment.

Align comment.

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.

Should this line be un-commented?

Should this line be un-commented?

So we are going to fail this test until calibration record is ready?

So we are going to fail this test until calibration record is ready?