td-firmware / firmware / App / Modes

StateTxDialysis.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 6
Last Commit: 27 May
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 29 May
2:57 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

2:33 pm

Vendor - TEL - Arpita Srivastava

Please add the min and max for tmp as well in the outputs.

Please add the min and max for tmp as well in the outputs.

2:25 pm

Sean Nash

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

Thursday 28 May
10:43 pm

Sean Nash

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

10:33 pm

Sean Nash

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

Wednesday 27 May
1:22 pm

Sean Nash

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

1:07 pm

Sean Nash

Add a doxygen comment above this array.

Add a doxygen comment above this array.

1:06 pm

Sean Nash

Add a doxygen comment above this array (similar to structures).

Add a doxygen comment above this array (similar to structures).

1:04 pm

Sean Nash

Add a doxygen comment above structure for the whole structure (see structure above for example).

Add a doxygen comment above structure for the whole structure (see structure above for example).

1:03 pm

Sean Nash

Add a doxygen comment for this definition.

Add a doxygen comment for this definition.

Tuesday 26 May
11:30 am

Raghu Kallala

remove camel case for SetPoint, instead use Setpoint Update line 659 too

remove camel case for SetPoint, instead use Setpoint
Update line 659 too

11:15 am

Vendor - TEL - Arpita Srivastava

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

11:14 am

Vendor - TEL - Arpita Srivastava

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

11:10 am

Vendor - TEL - Arpita Srivastava

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

11:09 am

Vendor - TEL - Arpita Srivastava

Looks like comment for 208 and 223 are swapped?

Looks like comment for 208 and 223 are swapped?

11:07 am

Vendor - TEL - Arpita Srivastava

please align the comments

please align the comments

10:36 am

Vendor - TEL - Arpita Srivastava

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

10:34 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines and check other functions too.

Please break it into two lines and check other functions too.

10:30 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:30 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:27 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

Please break it into two lines
Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

10:22 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:21 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:15 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:15 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:13 am

Vendor - TEL - Arpita Srivastava

TREAT_PARAMS_PROPERTIES should also be an input?

TREAT_PARAMS_PROPERTIES should also be an input?

10:05 am

Vendor - TEL - Arpita Srivastava

please add @param

please add @param

10:04 am

Vendor - TEL - Arpita Srivastava

please align the comment

please align the comment

Wednesday 20 May
12:09 pm

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

11:41 am

Sean Nash

Use #define for array size.

Use #define for array size.