td-firmware / firmware / App / Services

TxParams.h

Clone Tools

Stats

Commits this week: 5
Total Committers: 6
Last Commit: 27 May
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 29 May
2:57 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

2:33 pm

Vendor - TEL - Arpita Srivastava

Please add the min and max for tmp as well in the outputs.

Please add the min and max for tmp as well in the outputs.

2:25 pm

Sean Nash

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

9:58 am

Sean Nash

Why would change request from UI come in separate messages (1 for duration and 1 for volume)?

Why would change request from UI come in separate messages (1 for duration and 1 for volume)?

9:56 am

Sean Nash

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

9:52 am

Sean Nash

else reason is Invalid Request Format

else reason is Invalid Request Format

9:47 am

Sean Nash

Should check if iso UF volume + UF volume < max. And if user can do multiple iso uf sessions, you would check iso UF volume + any previous iso UF volume + UF volume. I don't know if there is a mini...

Should check if iso UF volume + UF volume < max. And if user can do multiple iso uf sessions, you would check iso UF volume + any previous iso UF volume + UF volume.
I don't know if there is a minimum iso UF volume.

9:45 am

Sean Nash

Looking for "less than current" only makes sense if user can do multiple iso UF sessions in a treatment. And if that's the case, we should be looking at how much time we've already spent doing iso ...

Looking for "less than current" only makes sense if user can do multiple iso UF sessions in a treatment. And if that's the case, we should be looking at how much time we've already spent doing iso UF instead of how much time we've spent in the HD or HDF treatment.

9:40 am

Sean Nash

I think we have to check whether the iso uf duration + treatment duration does not exceed maximum treatment duration. And I'm not sure if there is a minimum duration for iso uf, but if there is a m...

I think we have to check whether the iso uf duration + treatment duration does not exceed maximum treatment duration.
And I'm not sure if there is a minimum duration for iso uf, but if there is a minimum, it probably isn't the same as the minimum treatment duration.

9:37 am

Sean Nash

Just add this as an AND condition in the if statement above.

Just add this as an AND condition in the if statement above.

9:33 am

Sean Nash

If we are in treatment end state, the treatment is completed (no need to check that) and I don't think iso UF is a modality.

If we are in treatment end state, the treatment is completed (no need to check that) and I don't think iso UF is a modality.

9:31 am

Sean Nash

Do we need this? Check with Raghu. I don't think iso UF is a modality (at least not yet).

Do we need this? Check with Raghu. I don't think iso UF is a modality (at least not yet).

9:19 am

Sean Nash

Align all or none of the =

Align all or none of the =

9:14 am

Sean Nash

I don't think iso uf is considered a modality - at least not in phase 1 of development.

I don't think iso uf is considered a modality - at least not in phase 1 of development.

Thursday 28 May
10:43 pm

Sean Nash

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

10:33 pm

Sean Nash

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

Wednesday 27 May
1:22 pm

Sean Nash

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

1:07 pm

Sean Nash

Add a doxygen comment above this array.

Add a doxygen comment above this array.

1:06 pm

Sean Nash

Add a doxygen comment above this array (similar to structures).

Add a doxygen comment above this array (similar to structures).

1:04 pm

Sean Nash

Add a doxygen comment above structure for the whole structure (see structure above for example).

Add a doxygen comment above structure for the whole structure (see structure above for example).

1:03 pm

Sean Nash

Add a doxygen comment for this definition.

Add a doxygen comment for this definition.

Tuesday 26 May
11:30 am

Raghu Kallala

remove camel case for SetPoint, instead use Setpoint Update line 659 too

remove camel case for SetPoint, instead use Setpoint
Update line 659 too

11:15 am

Vendor - TEL - Arpita Srivastava

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

11:14 am

Vendor - TEL - Arpita Srivastava

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

11:10 am

Vendor - TEL - Arpita Srivastava

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

11:09 am

Vendor - TEL - Arpita Srivastava

Looks like comment for 208 and 223 are swapped?

Looks like comment for 208 and 223 are swapped?

11:07 am

Vendor - TEL - Arpita Srivastava

please align the comments

please align the comments

10:36 am

Vendor - TEL - Arpita Srivastava

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

10:34 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines and check other functions too.

Please break it into two lines and check other functions too.

10:30 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines