dd-firmware / firmware / App / Modes

ModeStandby.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 11 Aug
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Michael Garthwaite

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

Monday 17 Aug
4:59 pm

Sean Nash

Tuesday 11 Aug
10:18 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
Thursday 06 Aug
9:21 am

Vendor - TEL - Suresh Dharnala

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the inte...

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

9:13 am

Vendor - TEL - Suresh Dharnala

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic plac...

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic placeholder for the sampling mode/state and update the implementation and requirements once the feature is better defined.

Monday 03 Aug
11:05 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
Thursday 30 Jul
11:23 am

Vendor - TEL - Arpita Srivastava

10:23 am

Sean Nash

Wednesday 29 Jul
5:37 pm

Dara Navaei

Monday 27 Jul
2:22 pm

Vinayakam Mani

you need to bring in the new set of valves here as well.

you need to bring in the new set of valves here as well.

2:21 pm

Vinayakam Mani

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

2:15 pm

Vinayakam Mani

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode b...

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

1:43 pm

Vinayakam Mani

Align the indent. Replace RO to FP.

Align the indent. Replace RO to FP.

11:21 am

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

11:17 am

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

11:16 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:16 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:15 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:14 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Thursday 23 Jul
11:22 am

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

11:06 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

11:05 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

10:39 am

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?

10:31 am

Dara Navaei

Any fault alarm here?

Any fault alarm here?

10:18 am

Dara Navaei

Have these variables been initialized correctly?

Have these variables been initialized correctly?

Wednesday 22 Jul
1:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1:08 pm

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

1:07 pm

Sean Nash

Why commented out?

Why commented out?

Wednesday 15 Jul
9:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)