Activity leahi-common/TDDefs.h

You’re right. I should also check the busy status before transitioning to the GET_DATA state. I’ll update the measurement completion logic to first verify the busy bit is cleared, then validate the...

You’re right. I should also check the busy status before transitioning to the GET_DATA state. I’ll update the measurement completion logic to first verify the busy bit is cleared, then validate the BP data response code before moving to BP_DRIVER_GET_DATA_STATE.

10:46 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

Why do you have {} in the cases?

10:45 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

10:43 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

Where are these get functions defined? I can't find them.

4:27 pm

Vendor - TEL - Arpita Srivastava

3:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-3505-1
finished reviewing

12:11 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

12:02 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

11:28 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

Do we not need the module error alarm?

11:27 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
commented on review

This is not an atomic assignment, so we have to consider thread safety. If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec w...

This is not an atomic assignment, so we have to consider thread safety.
If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec which calls this driver's exec) and if the caller to this function will also be running from General Task (I believe it is since BPModule controller is the caller), then there is no thread safety issue and we should mention in the function header brief that this function should only be called from within the General Task.
If another task is involved (e.g. Priority Task is calling this function), this function could be interrupting the get data state while it is populating bpResults with new results and the caller would get a mix of old and new results (we would not want that).

11:21 am