td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Is this still necessary? Comment out before merging to staging.

Is this still necessary? Comment out before merging to staging.

Why are registers being repeated? Sync w/ latest HDD.

Why are registers being repeated? Sync w/ latest HDD.

Can we remove this commented out line of code?

Can we remove this commented out line of code?

Why is this commented out?

Why is this commented out?

Why is state transition and publish removed?

Why is state transition and publish removed?

Please address the commented code.

Please address the commented code.

Should we remove the commented code?

Should we remove the commented code?

We should manage the commented-out code.

We should manage the commented-out code.

break this line

break this line

break this line

break this line

Removed

Removed

Yes, Removed

Yes, Removed

Removed

Removed

Added

Added

Removed

Removed

Removed

Removed

Fixed

Fixed

No, I forget to remove

No, I forget to remove

Fixed

Fixed

Removed

Removed

Can we just remove these?

Can we just remove these?

Remove blank line.

Remove blank line.

Can we un-comment this call and remove TODO comment?

Can we un-comment this call and remove TODO comment?

Is this needed? Pre Tx Mode should be able to do what it needs through Valves.h.

Is this needed? Pre Tx Mode should be able to do what it needs through Valves.h.

Can we un-comment this stuff? I think we want it and I don't see anything we can't do. This is Denali code, so a one change is needed: there are now 2 air trap valves (H13 and H20), so we need to c...

Can we un-comment this stuff? I think we want it and I don't see anything we can't do.
This is Denali code, so a one change is needed: there are now 2 air trap valves (H13 and H20), so we need to close them both.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.