td-firmware

firmware

Clone Tools

Stats

Commits this week: 49
Total Committers: 15
Last Commit: 04 May
Commits this week: 49

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 04 May
7:01 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4248_(TD) RO Loop Testing / Demo: TD pinch valves to be in the correct state at standby and treatment
LEAHI-TD-FIRMWARE-LDT-4248_(TD) RO Loop Testing / Demo: TD pinch valves to be in the correct state at standby and treatment
6:51 pm

Sean Nash

LDT-4248: Home pinch valves in standby mode if not already homed.

Options
    • -15
    • +25
    ./App/Controllers/Valves.c
    • -0
    • +16
    ./App/Controllers/Valves.h
    • -19
    • +30
    ./App/Modes/ModeStandby.c
    • -1
    • +1
    ./App/Modes/StateTxBloodPrime.c
    • -0
    • +1
    ./App/Services/AlarmMgmtSWFaults.h
4:30 pm

Sean Nash

check alarm status instead of switch state.

check alarm status instead of switch state.

11:04 am

Vendor - TEL - Varshini Nagabooshanam

Uncommented

Uncommented

7:14 am

Vinayakam Mani and Michael Garthwaite

12:00 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

Sunday 03 May
11:59 pm

Sean Nash

Why is this service prefixed with "Tx"? Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

Why is this service prefixed with "Tx"?
Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

11:57 pm

Sean Nash

DrySelfTests unit.

DrySelfTests unit.

11:57 pm

Sean Nash

DrySelfTests unit initialized.

DrySelfTests unit initialized.

11:56 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:55 pm

Sean Nash

.. handles dry self-tests execution for pre-treatment and treatment modes.

.. handles dry self-tests execution for pre-treatment and treatment modes.

11:54 pm

Sean Nash

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

11:52 pm

Sean Nash

Calling signal function here seems circular (that's how we got here in the first place). Shouldn't we set state to the install state here instead?

Calling signal function here seems circular (that's how we got here in the first place).
Shouldn't we set state to the install state here instead?

11:50 pm

Sean Nash

Put before TxParams.

Put before TxParams.

11:50 pm

Sean Nash

I think Praneeth created a function for this. Make sure they're identical.

I think Praneeth created a function for this. Make sure they're identical.

11:46 pm

Sean Nash

11:46 pm

Sean Nash

11:44 pm

Sean Nash

11:43 pm

Sean Nash

Is the folder name necessary?

Is the folder name necessary?

11:42 pm

Sean Nash

Remove unnecessary spaces before =

Remove unnecessary spaces before =

11:41 pm

Sean Nash

Align =

Align =

11:41 pm

Sean Nash

Align =.

Align =.

11:41 pm

Sean Nash

Align =.

Align =.

11:40 pm

Sean Nash

We don't have to align =, but if you're going to have all of these spaces before the =, you should align.

We don't have to align =, but if you're going to have all of these spaces before the =, you should align.

11:38 pm

Sean Nash

Why are we doing this? Having a return here is against our coding standards (it's like a goto).

Why are we doing this?
Having a return here is against our coding standards (it's like a goto).

11:37 pm

Sean Nash

Describe what kind of services are being provided.

Describe what kind of services are being provided.

11:36 pm

Sean Nash

Consider separating the wait for door close to another state.

Consider separating the wait for door close to another state.

11:32 pm

Sean Nash

Why are we doing this?

Why are we doing this?

11:31 pm

Sean Nash

Describe what kind of services being provided.

Describe what kind of services being provided.

11:29 pm

Sean Nash

Should not change states in a signal function. Should set a request flag that gets looked at in dry self-tests state handler function which would return install state if the flag is set.

Should not change states in a signal function. Should set a request flag that gets looked at in dry self-tests state handler function which would return install state if the flag is set.