td-firmware / firmware / App / Modes

ModeInitPOST.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 04 May
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 04 May
4:30 pm

Sean Nash

check alarm status instead of switch state.

check alarm status instead of switch state.

Sunday 03 May
11:44 pm

Sean Nash

11:43 pm

Sean Nash

Is the folder name necessary?

Is the folder name necessary?

11:42 pm

Sean Nash

Remove unnecessary spaces before =

Remove unnecessary spaces before =

11:41 pm

Sean Nash

Align =

Align =

11:41 pm

Sean Nash

Align =.

Align =.

11:41 pm

Sean Nash

Align =.

Align =.

11:40 pm

Sean Nash

We don't have to align =, but if you're going to have all of these spaces before the =, you should align.

We don't have to align =, but if you're going to have all of these spaces before the =, you should align.

11:38 pm

Sean Nash

Why are we doing this? Having a return here is against our coding standards (it's like a goto).

Why are we doing this?
Having a return here is against our coding standards (it's like a goto).

11:37 pm

Sean Nash

Describe what kind of services are being provided.

Describe what kind of services are being provided.

11:36 pm

Sean Nash

Consider separating the wait for door close to another state.

Consider separating the wait for door close to another state.

11:32 pm

Sean Nash

Why are we doing this?

Why are we doing this?

11:31 pm

Sean Nash

Describe what kind of services being provided.

Describe what kind of services being provided.

11:29 pm

Sean Nash

Should not change states in a signal function. Should set a request flag that gets looked at in dry self-tests state handler function which would return install state if the flag is set.

Should not change states in a signal function. Should set a request flag that gets looked at in dry self-tests state handler function which would return install state if the flag is set.

Sunday 26 Apr
1:32 pm

Sean Nash

Remove blank line.

Remove blank line.

1:31 pm

Sean Nash

Move this transition function call to the transitionToPostTreatmentMode function below.

Move this transition function call to the transitionToPostTreatmentMode function below.

1:29 pm

Sean Nash

Invalid payload length shouldn't be a reject reason, it should cause a s/w fault (because it suggests the UI and TD software are not compatible versions).

Invalid payload length shouldn't be a reject reason, it should cause a s/w fault (because it suggests the UI and TD software are not compatible versions).

Wednesday 22 Apr
2:05 pm

Sean Nash

Not necessary

Not necessary

2:05 pm

Sean Nash

This command should be given once on way out of prior state instead of every 50ms while in this state. We also need to zero the timer counter at same time so the timeout check below works.

This command should be given once on way out of prior state instead of every 50ms while in this state.
We also need to zero the timer counter at same time so the timeout check below works.

2:03 pm

Sean Nash

Response needs to be sent immediately (in message handler function). This is too late.

Response needs to be sent immediately (in message handler function). This is too late.

2:02 pm

Sean Nash

We shouldn't need to do this door check if you've required door be closed for the state. Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed ...

We shouldn't need to do this door check if you've required door be closed for the state.
Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed and call with ( FALSE ) on transition into a state that doesn't require door to be closed. When required = TRUE, the switch monitor will trigger the door open alarm for you.

1:56 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:53 pm

Sean Nash

Not necessary if you give retract command on way out of prior state.

Not necessary if you give retract command on way out of prior state.

1:52 pm

Sean Nash

I don't think this if statement is necessary. We wouldn't be in this state if the ejector didn't extend already. I think we just want to see if BP is home again (completed 1 revolution) so we know ...

I don't think this if statement is necessary. We wouldn't be in this state if the ejector didn't extend already.
I think we just want to see if BP is home again (completed 1 revolution) so we know when to stop and go to next state.

1:48 pm

Sean Nash

Give ejector retract command and zero timer counter here too.

Give ejector retract command and zero timer counter here too.

1:47 pm

Sean Nash

Not needed if you do this on way out of prior state.

Not needed if you do this on way out of prior state.

1:46 pm

Sean Nash

Start BP and zero timer counter here.

Start BP and zero timer counter here.

1:46 pm

Sean Nash

Not necessary if fault property of alarm is TRUE.

Not necessary if fault property of alarm is TRUE.

1:45 pm

Sean Nash

Not necessary if you do this on way out of prior state.

Not necessary if you do this on way out of prior state.

1:44 pm

Sean Nash

Remove ejector homed stuff. Not needed.

Remove ejector homed stuff. Not needed.