td-firmware / firmware / App / Services

FpgaTD.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 7
Last Commit: 29 May
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Jun
9:51 am

Sean Nash

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD...

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

9:48 am

Sean Nash

Add doxygen comments to the right of each structure field.

Add doxygen comments to the right of each structure field.

9:47 am

Sean Nash

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

9:46 am

Sean Nash

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

9:44 am

Sean Nash

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

9:29 am

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

9:29 am

Sean Nash

Keep this blank line above group header.

Keep this blank line above group header.

9:28 am

Sean Nash

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Tuesday 02 Jun
4:22 pm

Sean Nash

Make sure UI s/w is looking for this message on the broadcast channel or change this channel to the TD=>UI channel if UI is looking for this message on that channel.

Make sure UI s/w is looking for this message on the broadcast channel or change this channel to the TD=>UI channel if UI is looking for this message on that channel.

Monday 01 Jun
7:02 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
Thursday 28 May
12:49 pm

Sean Nash

use ternary to make TRUE or FALSE.

use ternary to make TRUE or FALSE.

11:45 am

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

11:45 am

Vendor - TEL - Varshini Nagabooshanam

Yes

Yes

11:45 am

Vendor - TEL - Varshini Nagabooshanam

REmoved

REmoved

11:45 am

Vendor - TEL - Varshini Nagabooshanam

Moved

Moved

11:45 am

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

11:44 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

Wednesday 27 May
4:42 pm

Vendor - TEL - Arpita Srivastava

Which alarm?

Which alarm?

4:42 pm

Vendor - TEL - Arpita Srivastava

bpPublishTimerCtr is the output?

bpPublishTimerCtr is the output?

4:40 pm

Vendor - TEL - Arpita Srivastava

Input is none. Add @Alarms

Input is none.
Add @Alarms

4:38 pm

Vendor - TEL - Arpita Srivastava

Should we list the alarm ids? @Alarms?

Should we list the alarm ids? @Alarms?

4:36 pm

Vendor - TEL - Arpita Srivastava

requestAbortBPReading is the output?

requestAbortBPReading is the output?

4:36 pm

Vendor - TEL - Arpita Srivastava

requestPedsBPReading is the output?

requestPedsBPReading is the output?

4:35 pm

Vendor - TEL - Arpita Srivastava

requestAdultBPReading is the output?

requestAdultBPReading is the output?

4:35 pm

Vendor - TEL - Arpita Srivastava

pendingVitalsRequest is the output?

pendingVitalsRequest is the output?

4:34 pm

Vendor - TEL - Arpita Srivastava

We should initialize in the init function?

We should initialize in the init function?

4:31 pm

Vendor - TEL - Arpita Srivastava

bpMeasurementReady is an output?

bpMeasurementReady is an output?

4:29 pm

Vendor - TEL - Arpita Srivastava

nextState is the return value. Should we add requestAdultBPMeasurement, bpMeasurementReady and bpDriverError to outputs?

nextState is the return value.
Should we add requestAdultBPMeasurement, bpMeasurementReady and bpDriverError to outputs?

4:24 pm

Vendor - TEL - Arpita Srivastava

Where are we updating the bpResults?

Where are we updating the bpResults?

4:22 pm

Vendor - TEL - Arpita Srivastava

We should initialize this in init functions.

We should initialize this in init functions.