td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 25
Total Committers: 17
Last Commit: 29 May
Commits this week: 25

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Jun
2:01 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4027_Pre-Treatment - FW Implementation - 2/6:
LEAHI-TD-FIRMWARE-LDT-4027_Pre-Treatment - FW Implementation - 2/6:
12:29 pm

Vinayakam Mani and Sean Nash

9:51 am

Sean Nash

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD...

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

9:48 am

Sean Nash

Add doxygen comments to the right of each structure field.

Add doxygen comments to the right of each structure field.

9:47 am

Sean Nash

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

9:46 am

Sean Nash

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

9:44 am

Sean Nash

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

9:29 am

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

9:29 am

Sean Nash

Keep this blank line above group header.

Keep this blank line above group header.

9:28 am

Sean Nash

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Tuesday 02 Jun
4:22 pm

Sean Nash

Make sure UI s/w is looking for this message on the broadcast channel or change this channel to the TD=>UI channel if UI is looking for this message on that channel.

Make sure UI s/w is looking for this message on the broadcast channel or change this channel to the TD=>UI channel if UI is looking for this message on that channel.

Monday 01 Jun
7:02 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
4:34 pm

Vinayakam Mani

Maintain alphabetical order.

Maintain alphabetical order.

4:02 pm

Sean Nash

Eliza says we do allow multiple iso UF sessions in a treatment. So do we still need this else if, but looking at <= iso UF elapsed session time?

Eliza says we do allow multiple iso UF sessions in a treatment. So do we still need this else if, but looking at <= iso UF elapsed session time?

3:56 pm

Sean Nash

What about HDF?

What about HDF?

2:34 pm

Vendor - TEL - Jashwant Gantyada

Once UI software sends the volume and/or duration change request and once we change them, the UI software will send another request to confirm the displayed settings to the user and that is what is...

Once UI software sends the volume and/or duration change request and once we change them, the UI software will send another request to confirm the displayed settings to the user and that is what is being handled in this function.

1:54 pm

Sean Nash

return result;

return result;

1:53 pm

Sean Nash

Keep local result and set to TRUE or FALSE with a ternary.

Keep local result and set to TRUE or FALSE with a ternary.

1:50 pm

Sean Nash

Which setting does this message confirm (duration or volume)?

Which setting does this message confirm (duration or volume)?

11:02 am

Sean Nash

Align comment.

Align comment.

10:28 am

Vendor - TEL - Jashwant Gantyada

where are we calling an alarm? i think we are only sending event change data in completeBolusToCumulative() right?

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

10:25 am

Vendor - TEL - Jashwant Gantyada

do we need this block?

do we need this block?

10:09 am

Vinayakam Mani

update the comment as required: ml or L?

update the comment as required: ml or L?

10:00 am

Sean Nash

10:00 am

Sean Nash

Friday 29 May
2:57 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

2:33 pm

Vendor - TEL - Arpita Srivastava

Please add the min and max for tmp as well in the outputs.

Please add the min and max for tmp as well in the outputs.

2:25 pm

Sean Nash

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

9:56 am

Sean Nash

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

9:52 am

Sean Nash

else reason is Invalid Request Format

else reason is Invalid Request Format