Monitors

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Just use 0x0 and 0xFFFFFFFF

Just use 0x0 and 0xFFFFFFFF

NUM_OF_BATTERY_REGISTERS - 1

NUM_OF_BATTERY_REGISTERS - 1

Put 2 items at end of the list here: BATTERY_END_OF_LIST_TIME_TO_PUBLISH NUM_OF_BATTERY_REGISTERS

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

Put this one back to NUM_OF_BATTERY_DEVICES.

Put this one back to NUM_OF_BATTERY_DEVICES.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

Should this check be moved to the fluid bolus exec function?

Should this check be moved to the fluid bolus exec function?

LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
where are we calling an alarm? i think we are only sending event change data in completeBolusToCumulative() right?

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

do we need this block?

do we need this block?

update the comment as required: ml or L?

update the comment as required: ml or L?

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 7 more files in changeset.
LDT-3970: Addressed review comments for edit treatment parameters

Please add the min and max for tmp as well in the outputs.

Please add the min and max for tmp as well in the outputs.

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

Merge branch 'staging' into LDT-3970-edit-treatment-parameters-during-treatment

  1. … 2 more files in changeset.
Not a float.

Not a float.

Not a float.

Not a float.

Not a float anymore. Use u32Override function and no need to cast the pointer.

Not a float anymore. Use u32Override function and no need to cast the pointer.

Should we publish all registers read?

Should we publish all registers read?

Remove this comment since we have a comment to right.

Remove this comment since we have a comment to right.