td-firmware / firmware

source

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 17 Jul
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 21 Jul
5:14 pm

Sean Nash

Add comments to right.

Add comments to right.

5:13 pm

Sean Nash

2 blank lines before and after.

2 blank lines before and after.

5:09 pm

Sean Nash

Move declarations into this if scope.

Move declarations into this if scope.

5:08 pm

Sean Nash

Remove blank line.

Remove blank line.

5:07 pm

Sean Nash

Remove (void)

Remove (void)

5:06 pm

Sean Nash

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

Tuesday 30 Jun
11:44 am

Vendor - TEL - Arpita Srivastava

this function should not return anything.

this function should not return anything.

10:01 am

Vendor - TEL - Arpita Srivastava

Please rename all the sPump registers as h10 for consistency.

Please rename all the sPump registers as h10 for consistency.

9:56 am

Vendor - TEL - Arpita Srivastava

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Saturday 27 Jun
9:11 am

Sean Nash

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Friday 26 Jun
3:16 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

Wednesday 24 Jun
4:14 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Not required here since we are initializing in the main

Not required here since we are initializing in the main

4:12 pm

Vendor - TEL - Varshini Nagabooshanam

Yes removed

Yes removed

4:12 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:11 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

2:34 pm

Vendor - TEL - Arpita Srivastava

fpgaActuatorSetPoints is an output. Input is none.

fpgaActuatorSetPoints is an output.
Input is none.

12:50 pm

Sean Nash

Include "BPModule.h".

Include "BPModule.h".

12:49 pm

Sean Nash

BPModule is just one of the controllers - move this up into the controllers section.

BPModule is just one of the controllers - move this up into the controllers section.

12:48 pm

Sean Nash

We should not comment this out.

We should not comment this out.

12:47 pm

Sean Nash

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

12:46 pm

Sean Nash

We are already executing this from TaskGeneral.c. Remove from here.

We are already executing this from TaskGeneral.c. Remove from here.

12:45 pm

Sean Nash

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

12:43 pm

Sean Nash

I think all flags are outputs (not just adult).

I think all flags are outputs (not just adult).

12:41 pm

Sean Nash

These look like outputs to me (not inputs).

These look like outputs to me (not inputs).

Monday 22 Jun
4:36 pm

Sean Nash

Merge these 3 override functions (and message IDs) into one "array style" override function.

Merge these 3 override functions (and message IDs) into one "array style" override function.