dd-firmware / firmware / App / Monitors

Conductivity.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 7
Last Commit: 14 Jul
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 14 Jul
3:06 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Conductivity.c
  2. … 8 more files in changeset.
2:58 pm

Michael Garthwaite

Saturday 11 Jul
5:38 am

Vendor - TEL - Sameer Poyil

right now pre and post are same. make a TODO to update post later

right now pre and post are same. make a TODO to update post later

5:36 am

Vendor - TEL - Sameer Poyil

its mixing control interval

its mixing control interval

Friday 10 Jul
4:49 pm

Vendor - TEL - Sameer Poyil

could you document th math behind the calculation also

could you document th math behind the calculation also

Thursday 09 Jul
2:13 pm

Sean Nash

Wednesday 08 Jul
1:48 pm

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

9:39 am

Michael Garthwaite

LDT-4734: code review comments

Options
    • -24
    • +24
    ./Conductivity.c
  2. … 2 more files in changeset.
Monday 06 Jul
12:59 pm

Sean Nash

What is 4 (or 2)? Should be #define or enum or const.

What is 4 (or 2)? Should be #define or enum or const.

Wednesday 01 Jul
9:04 pm

Vendor - TEL - Sameer Poyil

please align this comments with below structure

please align this comments with below structure

9:03 pm

Vendor - TEL - Sameer Poyil

Please align the comments

Please align the comments

8:59 pm

Vendor - TEL - Sameer Poyil

could you please align it ?

could you please align it ?

6:08 pm

Sean Nash

Add blank line (should be 2 before test support banner).

Add blank line (should be 2 before test support banner).

6:07 pm

Sean Nash

Remove blank line.

Remove blank line.

6:06 pm

Sean Nash

Needs doxygen comments.

Needs doxygen comments.

1:18 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:18 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:17 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:17 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:17 pm

Michael Garthwaite

Reverted change. Added uncompensated conductivity to the conductivity publishing

Reverted change. Added uncompensated conductivity to the conductivity publishing

1:16 pm

Michael Garthwaite

LDT-4734: code review comments

Options
    • -24
    • +51
    ./Conductivity.c
  2. … 2 more files in changeset.
1:00 pm

Michael Garthwaite

Revert "LDT-4734: updates conductivity resistance messages."

This reverts commit 14277e7c55fbb8407612572aca191ffae0835796.

Options
    • -0
    • +30
    ./Conductivity.c
  2. … 1 more file in changeset.
11:02 am

Vinayakam Mani

space after if.

space after if.

11:02 am

Vinayakam Mani

Space after if.

Space after if.

10:59 am

Vinayakam Mani

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

10:58 am

Vendor - TEL - Jashwant Gantyada

10:57 am

Vendor - TEL - Jashwant Gantyada

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

10:57 am

Vinayakam Mani

Remove empty line.

Remove empty line.

10:54 am

Vinayakam Mani

Align the indentation

Align the indentation

10:54 am

Vinayakam Mani

Align the indentation.

Align the indentation.