td-firmware / firmware / App / Services

FpgaTD.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 7
Last Commit: 17 Jun
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 20 Jul
5:00 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

Thursday 09 Jul
9:00 am

Sean Nash

If this reserved2 is a U32, next register would be at 288 (not 285). Should we make reserved2 a U08?

If this reserved2 is a U32, next register would be at 288 (not 285). Should we make reserved2 a U08?

Monday 06 Jul
1:07 pm

Sean Nash

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

1:05 pm

Sean Nash

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

12:26 pm

Sean Nash

Do we still need this?

Do we still need this?

10:39 am

Sean Nash

Tuesday 30 Jun
1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

11:44 am

Vendor - TEL - Arpita Srivastava

this function should not return anything.

this function should not return anything.

10:01 am

Vendor - TEL - Arpita Srivastava

Please rename all the sPump registers as h10 for consistency.

Please rename all the sPump registers as h10 for consistency.

9:56 am

Vendor - TEL - Arpita Srivastava

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Wednesday 24 Jun
4:14 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Not required here since we are initializing in the main

Not required here since we are initializing in the main

4:12 pm

Vendor - TEL - Varshini Nagabooshanam

Yes removed

Yes removed

4:12 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:11 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

2:34 pm

Vendor - TEL - Arpita Srivastava

fpgaActuatorSetPoints is an output. Input is none.

fpgaActuatorSetPoints is an output.
Input is none.

12:50 pm

Sean Nash

Include "BPModule.h".

Include "BPModule.h".

12:49 pm

Sean Nash

BPModule is just one of the controllers - move this up into the controllers section.

BPModule is just one of the controllers - move this up into the controllers section.

12:48 pm

Sean Nash

We should not comment this out.

We should not comment this out.

12:47 pm

Sean Nash

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

12:46 pm

Sean Nash

We are already executing this from TaskGeneral.c. Remove from here.

We are already executing this from TaskGeneral.c. Remove from here.

12:45 pm

Sean Nash

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

12:43 pm

Sean Nash

I think all flags are outputs (not just adult).

I think all flags are outputs (not just adult).

12:41 pm

Sean Nash

These look like outputs to me (not inputs).

These look like outputs to me (not inputs).

Monday 22 Jun
9:11 am

Vendor - TEL - Varshini Nagabooshanam