dd-firmware / firmware / App / Controllers

MixingControl.c

Clone Tools

Stats

Commits this week: 12
Total Committers: 3
Last Commit: 25 Jun
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Vinayakam Mani

Same as above.

Same as above.

1 hr ago

Vinayakam Mani

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

1 hr ago

Vinayakam Mani

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

Thursday 25 Jun
4:20 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
4:14 pm

Vendor - TEL - Sameer Poyil

it shouldn't be the default value

it shouldn't be the default value

4:11 pm

Vendor - TEL - Sameer Poyil

3:04 pm

Vinayakam Mani

Wednesday 24 Jun
2:53 pm

Vendor - TEL - Sameer Poyil

2:47 pm

Vinayakam Mani

Space after if.

Space after if.

2:45 pm

Vinayakam Mani

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

2:40 pm

Vinayakam Mani

remove empty space after d66pressure variable. or match the indent to previous statement.

remove empty space after d66pressure variable. or match the indent to previous statement.

2:36 pm

Vinayakam Mani

Add a TODO comment (remove later): this should be handled in IO/FP module.

Add a TODO comment (remove later): this should be handled in IO/FP module.

2:33 pm

Vinayakam Mani

Update comment.

Update comment.

2:32 pm

Vinayakam Mani

Add comment.

Add comment.

2:31 pm

Vinayakam Mani

Depressurize?

Depressurize?

2:22 pm

Vinayakam Mani

Fix the typo.

Fix the typo.

1:49 pm

Vendor - TEL - Sameer Poyil

moved to general task

moved to general task

1:02 pm

Vendor - TEL - Sameer Poyil

12:50 pm

Vendor - TEL - Sameer Poyil

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

Tuesday 23 Jun
3:38 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
2:47 pm

Vinayakam Mani

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband co...

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

2:40 pm

Vinayakam Mani

This should return POST conductivity.

This should return POST conductivity.

2:20 pm

Vinayakam Mani

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

2:04 pm

Vinayakam Mani

Init PI Controls missing here.

Init PI Controls missing here.

1:57 pm

Vinayakam Mani

13734.87F

13734.87F

Monday 22 Jun
12:29 pm

Vinayakam Mani

Can we move this exec at task level, independent of Drybicart operations?

Can we move this exec at task level, independent of Drybicart operations?

12:27 pm

Vinayakam Mani

Comment missing?

Comment missing?

12:18 pm

Vinayakam Mani

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5...

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

12:14 pm

Vinayakam Mani

both acid and bicarb mix volume

both acid and bicarb mix volume

12:07 pm

Vinayakam Mani

Add MULTIPLIER at the end.

Add MULTIPLIER at the end.