leahi-dialin / leahi_dialin / ui

fp_messaging.py

Clone Tools

Stats

Commits this week: 1
Total Committers: 5
Last Commit: 25 Jun
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jun
5:33 pm

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

2:51 pm

Behrouz NematiPour

Tuesday 23 Jun
10:40 am

Zoltan Miskolci

updated

updated

10:32 am

Raghu Kallala

Remove extra spaces before comment

Remove extra spaces before comment

9:36 am

Nicholas Ramirez

9:19 am

Dara Navaei

LDT-4747: SW Integration - FP Diagnostics - DialIn
LDT-4747: SW Integration - FP Diagnostics - DialIn
Thursday 18 Jun
4:33 pm

Tiffany Mejia and Behrouz NematiPour

Thursday 11 Jun
1:31 pm

Sean Nash

1:30 pm

Sean Nash

11:55 am

Nicholas Ramirez

LDT-4680 Power Control and POST - SW - 01 - Power Control - R&I - 08: DEV - Dialin Implementation

add confirm request

Options
    • -1
    • +1
    ./fp_messaging.py
  2. … 1 more file in changeset.
Tuesday 09 Jun
8:35 am

Dara Navaei

LEAHI-DIALIN-LDT-4672_Power Control and POST - SW - 01 - Power Control - R&I
LEAHI-DIALIN-LDT-4672_Power Control and POST - SW - 01 - Power Control - R&I
Monday 08 Jun
11:20 am

Dara Navaei

LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin
LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin
Monday 01 Jun
4:20 pm

Zoltan Miskolci

4:00 pm

Zoltan Miskolci

Merge branch 'LDT-3904-opmode-the-operation-mode-broad' into staging

Options
    • -17
    • +17
    ./fp_messaging.py
  2. … 12 more files in changeset.
8:01 am

Raghu Kallala

Friday 29 May
10:05 am

Michael Garthwaite

Friday 22 May
1:22 pm

Nicholas Ramirez

12:45 pm

Behrouz NematiPour

12:45 pm

Behrouz NematiPour

Thursday 21 May
5:09 pm

Zoltan Miskolci

references to Denali has been removed

references to Denali has been removed

11:31 am

Zoltan Miskolci

Removed Denali reference

Options
    • -17
    • +17
    ./fp_messaging.py
  2. … 75 more files in changeset.
7:44 am

Raghu Kallala

Shouldn't we use Leahi instead of Denali?

Shouldn't we use Leahi instead of Denali?

Thursday 07 May
3:09 pm

Stephen Quong

Monday 04 May
5:46 pm

Dara Navaei

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
3:01 pm

Nicholas Ramirez

LDT-4201 NON-FEATURE: SW Misc & Enhc - SW - 01 - Water/Dialysate Sample - R&I - 08: DEV - Dialin Implementation

fix payload

Options
    • -1
    • +1
    ./fp_messaging.py
2:20 pm

Nicholas Ramirez

LDT-4201 NON-FEATURE: SW Misc & Enhc - SW - 01 - Water/Dialysate Sample - R&I - 08: DEV - Dialin Implementation

aded RO rejectio nratio

Options
    • -0
    • +30
    ./fp_messaging.py
Thursday 30 Apr
10:27 am

Sean Nash