leahi-dialin / leahi_dialin / ui

td_messaging.py

Clone Tools

Stats

Commits this week: 2
Total Committers: 6
Last Commit: 25 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jun
5:33 pm

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

3:20 pm

Nicholas Ramirez

change to td_powerOff_wARNING

change to td_powerOff_wARNING

11:05 am

Zoltan Miskolci

Could you just leave it as or TBD_B7 = 0xB7 ? So it will be easy to see that the msg id location is free to use

Could you just leave it as or TBD_B7 = 0xB7 ?
So it will be easy to see that the msg id location is free to use

Tuesday 23 Jun
3:10 pm

Nicholas Ramirez

10:40 am

Zoltan Miskolci

updated

updated

10:32 am

Raghu Kallala

Remove extra spaces before comment

Remove extra spaces before comment

9:49 am

Dara Navaei

LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I
LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I
9:36 am

Nicholas Ramirez

9:36 am

Nicholas Ramirez

9:35 am

Nicholas Ramirez

Thursday 18 Jun
4:53 pm

Behrouz NematiPour

Merge branch 'feature/LDT-4692-tx-adjust-vitals-alarm-limits' into staging

Options
    • -0
    • +27
    ./td_messaging.py
  2. … 1 more file in changeset.
4:49 pm

Dara Navaei

LEAHI-DIALIN-LDT-4632_NON-FEATURE: SW Misc & Enhc - SW - 01 - SW Integration - TD Diagnostics - R&I
LEAHI-DIALIN-LDT-4632_NON-FEATURE: SW Misc & Enhc - SW - 01 - SW Integration - TD Diagnostics - R&I
4:48 pm

Behrouz NematiPour

Merge branch 'feature/LDT-4511-treatment-logs' into staging

Options
    • -0
    • +35
    ./td_messaging.py
4:42 pm

Behrouz NematiPour

Merge branch 'feature/LDT-4632-integration-td-diagnostics' into staging

Options
    • -46
    • +75
    ./td_messaging.py
4:23 pm

Behrouz NematiPour

resolved.

resolved.

Wednesday 17 Jun
1:33 pm

Nicholas Ramirez

LDT-4640 NON-FEATURE: SW Misc & Enhc - SW - 01 - SW Integration - TD Diagnostics - R&I - 08: DEV - Dialin Implementation

update td diagnostic broadastrs

Options
    • -32
    • +49
    ./td_messaging.py
9:27 am

Nicholas Ramirez

LDT-4640 NON-FEATURE: SW Misc & Enhc - SW - 01 - SW Integration - TD Diagnostics - R&I - 08: DEV - Dialin Implementation

Options
    • -24
    • +36
    ./td_messaging.py
Friday 12 Jun
10:06 am

Nicholas Ramirez

i pulled staging and should all be there

i pulled staging and should all be there

10:01 am

Nicholas Ramirez

Merge remote-tracking branch 'origin/staging' into feature/LDT-4511-treatment-logs

Options
    • -109
    • +109
    ./td_messaging.py
Thursday 11 Jun
1:31 pm

Sean Nash

1:30 pm

Sean Nash

1:10 pm

Sean Nash

11:55 am

Nicholas Ramirez

LDT-4680 Power Control and POST - SW - 01 - Power Control - R&I - 08: DEV - Dialin Implementation

add confirm request

Options
    • -12
    • +31
    ./td_messaging.py
  2. … 1 more file in changeset.
Tuesday 09 Jun
2:15 pm

Nicholas Ramirez

LDT-4700 NON-FEATURE: SW Misc & Enhc - SW - 01 - Treatment adjustments - Vitals alarm limits - R&I - 08: DEV - Dialin Implementation

fix eror

Options
    • -2
    • +2
    ./td_messaging.py
11:48 am

Dara Navaei

LEAHI-DIALIN-LDT-4692_NON-FEATURE: SW Misc & Enhc - SW - 01 - Treatment adjustments - Vitals alarm limits - R&I
LEAHI-DIALIN-LDT-4692_NON-FEATURE: SW Misc & Enhc - SW - 01 - Treatment adjustments - Vitals alarm limits - R&I
11:47 am

Nicholas Ramirez

LDT-4700 NON-FEATURE: SW Misc & Enhc - SW - 01 - Treatment adjustments - Vitals alarm limits - R&I - 08: DEV - Dialin Implementation

add message id and repsonse

Options
    • -0
    • +27
    ./td_messaging.py
  2. … 1 more file in changeset.
8:35 am

Dara Navaei

LEAHI-DIALIN-LDT-4672_Power Control and POST - SW - 01 - Power Control - R&I
LEAHI-DIALIN-LDT-4672_Power Control and POST - SW - 01 - Power Control - R&I