leahi-dialin

Clone Tools

Stats

Commits this week: 61
Total Committers: 16
Last Commit: 25 Jun
Commits this week: 61

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
34 mins ago

Zoltan Miskolci

2 hrs ago

Dara Navaei

LEAHI-DIALIN-LDT-4878_(Dialin) The wheel file generated by the build.sh command failed to install
LEAHI-DIALIN-LDT-4878_(Dialin) The wheel file generated by the build.sh command failed to install
2 hrs ago

Michael Garthwaite

3 hrs ago

Zoltan Miskolci

Being generic is the whole point of it. It was renamed because this is a dialin dedicated to Leahi unit and calling the messages DenaliMessage is misleading. It was renamed to CanMessage for 2 reas...

Being generic is the whole point of it.
It was renamed because this is a dialin dedicated to Leahi unit and calling the messages DenaliMessage is misleading.
It was renamed to CanMessage for 2 reason:
1. This is a Leahi only dialin, so there is no need to differentiate between different type of Can Messages as there would be only 1 type
2. Calling it CanMessage will make it more future compatible when the dialin get copied over for a new unit development (unlikely in the foreseeable future but possible), removing the need to rename it again

3 hrs ago

Zoltan Miskolci

There is no Leahi or Denali CANChannels. There are CAN channels and the naming is what that channel is being used for. The collision occurs in the FW and the FW handles it before sending out a mess...

There is no Leahi or Denali CANChannels.
There are CAN channels and the naming is what that channel is being used for.
The collision occurs in the FW and the FW handles it before sending out a message.
When reading a CAN, there are no collisions, so there are no priorities. So I have no clue what you want here.

3 hrs ago

Zoltan Miskolci

done

done

3 hrs ago

Zoltan Miskolci

I have no idea what you are referring to as the link is not working. The need to define the type and the name of the data being read is necessary, so if it's not here it will be somewhere else, tha...

I have no idea what you are referring to as the link is not working.
The need to define the type and the name of the data being read is necessary, so if it's not here it will be somewhere else, that we can't escape.
Exporting that to different files won't serve a purpose and will only increase complexity as when debugging you will need to reference a separate file.
For the defs it made sense as they are used multiple places, but what a message contains is a single use place, so storing it separately is meaningless as it won't have any use outside of this single function.

4 hrs ago

Michael Garthwaite

4 hrs ago

Michael Garthwaite

Friday 26 Jun
4:56 pm

Raghu Kallala

4:21 pm

Zoltan Miskolci

fixed

fixed

3:17 pm

Dara Navaei

LEAHI-DIALIN-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
LEAHI-DIALIN-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
2:13 pm

Raghu Kallala

fix typo

fix typo

Thursday 25 Jun
5:33 pm

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

4:32 pm

Dara Navaei

LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
4:13 pm

Vendor - TEL - Sameer Poyil

4:13 pm

Zoltan Miskolci

4:07 pm

Zoltan Miskolci

3:55 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-4612-dialysate-composition-dialin-fix-for-mixing-control into staging

Options
    • -1
    • +3
    /leahi_dialin/common/msg_ids.py
3:20 pm

Nicholas Ramirez

change to td_powerOff_wARNING

change to td_powerOff_wARNING

2:51 pm

Behrouz NematiPour

11:05 am

Zoltan Miskolci

Could you just leave it as or TBD_B7 = 0xB7 ? So it will be easy to see that the msg id location is free to use

Could you just leave it as or TBD_B7 = 0xB7 ?
So it will be easy to see that the msg id location is free to use

8:47 am

Dara Navaei

LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
Wednesday 24 Jun
9:23 pm

Vinayakam Mani

9:14 pm

Vendor - TEL - Sameer Poyil

LDT-4612 addressed review commend

Options
    • -2
    • +2
    /leahi_dialin/dd/modules/mixing_cntrl.py
2:56 pm

Vinayakam Mani

Update the name.

Update the name.

2:39 pm

Vendor - TEL - Sameer Poyil